From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6D8895B40; Tue, 25 Sep 2018 11:50:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2042921F11; Tue, 25 Sep 2018 05:50:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 25 Sep 2018 05:50:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=x4qh5Cx5YS9NYXgnxKR2jgW73N AxK6Zbq6QnxtxFORg=; b=D8o2M130Sx9pF39hDHv9LpWx0INxFPnbeU6lKNpFBB WYZn9Bu2rdv5peL6rPJS4qydRNKDG0W9WjJ/d4yHLh7E2+RlknM9lbocHMzmHcWz LPbU2x9YiBWmmClJuQyGg/cmRtVRPvvi3Al7lo92/ntFxMvjNgeM30Pp3XnmdCjy g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=x4qh5C x5YS9NYXgnxKR2jgW73NAxK6Zbq6QnxtxFORg=; b=epgN7lBBgyWlsPEXDlf0dD f3ZpheRLtinwD1m+SSHA6FOKkLNM1lHMNhkxMaJBkTu4llZrneAraOE/1vickv3u 6dJUtuLwzG1lHjXcft9KNvKY050HxPtyajj2GA6n+wLQjUW4FKFNeaUWtIssvFxS 3+KCivMWfqtSmAv2Q/2Fmn/z0PxeIYZHd8Hl4bGCxta2oioXtr5PhsJeto4ZDQAO i7g9LkNCWXcK5toOa55FbWaSrwny8BQygBDZ8Xz3BzT9PBR2xX3d5xPPwAM6N2oU lmSgnNf1g9Wb/wrj326645rKrsSdB8lpXNUGH3WVBf/FbFC3YmaEKCKWYHIXJ+gw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1FFC1E484F; Tue, 25 Sep 2018 05:50:07 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: Nikhil Rao , dev@dpdk.org, stable@dpdk.org Date: Tue, 25 Sep 2018 11:50:06 +0200 Message-ID: <2681112.ibEmUdxJTb@xps> In-Reply-To: <20180925091526.GA13128@jerin> References: <1536150078-89772-1-git-send-email-nikhil.rao@intel.com> <1537865352-114085-1-git-send-email-nikhil.rao@intel.com> <20180925091526.GA13128@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix port id argument in Rx adapter caps API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 09:50:08 -0000 25/09/2018 11:15, Jerin Jacob: > -----Original Message----- > > Date: Tue, 25 Sep 2018 14:19:12 +0530 > > From: Nikhil Rao > > To: jerin.jacob@caviumnetworks.com > > CC: dev@dpdk.org, Nikhil Rao , stable@dpdk.org > > Subject: [PATCH v2] eventdev: fix port id argument in Rx adapter caps API > > X-Mailer: git-send-email 1.8.3.1 > > > > > > Make the ethernet port id passed into > > rte_event_eth_rx_adapter_caps_get() 16 bit. > > > > Also, update the event rx adapter test to use 16 bit > > ethernet port ids. > > > > Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit") > > Cc: stable@dpdk.org > > > > Signed-off-by: Nikhil Rao > > Acked-by: Jerin Jacob > > --- > > > > v2: > > * squash changes to autotest and library into a single patch (Jerin Jacob) > > * add update to release notes (Jerin Jacob) > > > > lib/librte_eventdev/rte_eventdev.h | 2 +- > > lib/librte_eventdev/rte_eventdev.c | 2 +- > > test/test/test_event_eth_rx_adapter.c | 6 +++--- > > doc/guides/rel_notes/release_18_11.rst | 4 +++- > > lib/librte_eventdev/Makefile | 2 +- > > Missing version update in lib/librte_eventdev/meson.build. See version= > > > 5 files changed, 9 insertions(+), 7 deletions(-) > > > > ABI Changes > > ----------- > > @@ -162,7 +164,7 @@ The libraries prepended with a plus sign were incremented in this version. > > librte_distributor.so.1 > > librte_eal.so.8 > > librte_ethdev.so.10 > > - librte_eventdev.so.4 > > + + librte_eventdev.so.6 > > Can you send a separate standalone patch to fixup doc/guides/rel_notes/release_18_08.rst > release notes. The version(change to librte_eventdev.so.5) should have been > updated in change set in 3810ae4357. > > +Thomas, > In case if he has difference in opinion on updating released release note file. I prefer such changes being atomic.