From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F324A034F; Tue, 11 Jan 2022 15:32:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77D8342724; Tue, 11 Jan 2022 15:32:39 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 1EEB241143 for ; Tue, 11 Jan 2022 15:32:38 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 0837C3200E1A; Tue, 11 Jan 2022 09:32:36 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 11 Jan 2022 09:32:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= sqhHqfvC6gc1HxJvSkvCwKFziu7jA7mEsaDNe1clAIs=; b=UtNocK5Z9M9RQ5Kf 4TuExRqQ97RVVRm6VlellaBsKp15GawiukrN9YKyVbt7x8R64/9wBJWMWsBw469u TOfEElDNPErSbM4kjLFtLH2hxPnJyNbdEwCBmXkNyKwIgUGZXVtg2JOvsHTXUGQw Oxl5DM8Vh47js8CTbzdHvf3RtUKjxu6vmtNHvpahi2bD/kNGFySBPRQz2Qa+qgeD I/EDE+HikqjVZPwyz6W/Ok0djgiZE3V4ZAWP3QDSCOR3z97aCEEnsvgUrnNhQzfe ZacId2gROMuXmYhHgCVIjNmgAzAbz3ibXJ8QMzSZ32J0oy58qibDQGEwsC0CBAZq 1JY8Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=sqhHqfvC6gc1HxJvSkvCwKFziu7jA7mEsaDNe1clA Is=; b=KLscTAl7CUNFggso+PaCdv6HB5/JpvQwBrbwQVA9eGDXE3eVR9gq6dEz3 ELQg5pnal83Ln/0Edn1xjCMAnSvmt+rpGQoyrWRqCubR4nDAgSqeRnsGGyg7mW7c ZO96q6+YAP7ljLbtu8Ows5MvuLfZOqec5oP77tRmQCugJLFg85A2K8+6KBYyR7qZ jRdpempWKAme4gYxrrhKJbwQhGmJFxHMWdanqE3hkX86uVKDycOorNeCeX918FCS +/v1IPqMyTW2U93BmGfQDlV0/lcX1fwL+RrqkF8LId2BN1ITu+8UYlt4JY/hmnRj SAgtVRBUfQazjb3cJ1BrpcMrqWNfg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudehfedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Jan 2022 09:32:35 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-kmods v2] linux/igb_uio: fix build for switch fall through Date: Tue, 11 Jan 2022 15:32:34 +0100 Message-ID: <2684876.BEx9A2HvPv@thomas> In-Reply-To: <20211216120349.2088759-1-ferruh.yigit@intel.com> References: <20211215184859.1859870-1-ferruh.yigit@intel.com> <20211216120349.2088759-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/12/2021 13:03, Ferruh Yigit: > Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't > take any fall through comments into account but only uses compiler > 'fallthrough' attribute to document fall through action is intended. > > "falls through" comment was used in the code which is causing a build > error now, this patch converts comment to the 'fallthrough' macro > defined in the Linux. > > To cover the case where an old Linux version doesn't have the macro, > defined it in the compatibility header too. > > Signed-off-by: Ferruh Yigit Applied, thanks.