From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F08ADA04DC;
	Mon, 26 Oct 2020 15:30:09 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id CCC302B9D;
	Mon, 26 Oct 2020 15:30:08 +0100 (CET)
Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com
 [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 9CBF31E2B
 for <dev@dpdk.org>; Mon, 26 Oct 2020 15:30:06 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailnew.nyi.internal (Postfix) with ESMTP id 1F8E15804AB;
 Mon, 26 Oct 2020 10:30:05 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Mon, 26 Oct 2020 10:30:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 VMkfpDOwKWP+ayfzYtiXzSuUtlKGx15J6y0uEkET8Yc=; b=FvKQz8/89Nsr0y1L
 efdXpYqq4asTQGmQU/yCftBbNiDfYK/oz6xwopsB4bwSKzZmA++GBlkKv06xG2hF
 WhUOj2FCV5Ev0iMt/gVZISBDBPZcc8d0YkEO0V4d5G4uxPv5RnKknF+vYicB8WA6
 ScOanIbb4YV7KXBTBlr+UZztO6+Q+Xfgf0vogl/YAJcWjyiBnaw0ChAH5yc8qw5a
 XNxYCg09duJ9p5en6BFmhOy157DKWMqAFDhqH3AsFbHALTeZD++oG54j7BWkJ/LB
 QKeHSyz72G9y4I26OQQLtPXDZmhRBDSMG/aPduMpeBrkFcEeBL8kEtlymWIKGP/C
 Anai9Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=VMkfpDOwKWP+ayfzYtiXzSuUtlKGx15J6y0uEkET8
 Yc=; b=iIiO1TatZ+ynks9jOprdo271SPZjgpXW3459fwe4wGMxSlQ5tPsd4A57x
 MyNmnc4bQ+EPaqyqCQhmGgV9sCq7CgaDzjVLKzY6+yoUYQZSQ5uZf4t2VNUFRiA6
 ReT/+dmo4b95MZMs+8AX82ZpdycsXCvMdSbsm+IKde77PW0LkAPvYbYoFMzrMQdA
 IVs9uduBUZINOZCZGemdTRKEFXWNLclmiLwKUNBE+WD+JAJym1Bs9lhFaTWL7wJM
 bCjOvc867IO1y/2XkgBH3Eb8UAkWtpffmVJXzzLmRWsktbl1Si5hlEwWZ46ZvU7m
 jrP68LP5tKdU4+oAnTFjl7sKxYSmA==
X-ME-Sender: <xms:a92WXxNYEZ_EgVb6FK0jNqjRKMl6j8vmSnd1XUQhnmGtuQBJvrwyMw>
 <xme:a92WXz-u_UKx30vXwuB74boCSBCzSy8PH39xZKSfuL0_dOMBQHPg74ADBlgMoeMsZ
 1X60rsLw5Vwolzr4w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeejgddvkecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
 frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
 iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
 iivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
 nhdrnhgvth
X-ME-Proxy: <xmx:a92WXwQjBKx9bYWFEF7l0jmfNFpyIfG3HjrjeVK2KTffGoCMA_N3_g>
 <xmx:a92WX9vsy_k7ln2ji5KY6YS_nhR7pBsa70ZzZeeGke7xhe60PX9kjw>
 <xmx:a92WX5dfyBLRdTq1jh6D0-bK1x4ANrI98U7zCXtA-DJKAMnRlQYAuQ>
 <xmx:bd2WX00-ORNV3qSGHSVzLj7O4sTJ6G0fD8HCl0WqKA2I86BkW4O6FA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id A1C9B3064687;
 Mon, 26 Oct 2020 10:30:01 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty <declan.doherty@intel.com>,
 Ankur Dwivedi <adwivedi@marvell.com>, Anoob Joseph <anoobj@marvell.com>,
 Jeff Guo <jia.guo@intel.com>, Haiyue Wang <haiyue.wang@intel.com>,
 Jerin Jacob <jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Radu Nicolau <radu.nicolau@intel.com>,
 Ray Kinsella <mdr@ashroe.eu>
Date: Mon, 26 Oct 2020 15:30:00 +0100
Message-ID: <2687436.iHeDq2mSAm@thomas>
In-Reply-To: <CAJFAV8zKQpkg3zme7PqUCD0Xf9=mwc1LbajUH6dn6rY7Y04k2w@mail.gmail.com>
References: <20201026052105.1561859-1-thomas@monjalon.net>
 <20201026052105.1561859-6-thomas@monjalon.net>
 <CAJFAV8zKQpkg3zme7PqUCD0Xf9=mwc1LbajUH6dn6rY7Y04k2w@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 05/15] security: switch metadata to dynamic
	mbuf field
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/10/2020 11:41, David Marchand:
> On Mon, Oct 26, 2020 at 6:21 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > +/* Dynamic mbuf field for device-specific metadata */
> > +static const struct rte_mbuf_dynfield rte_security_dynfield_desc = {
> > +       .name = RTE_SECURITY_DYNFIELD_NAME,
> > +       .size = sizeof(RTE_SECURITY_DYNFIELD_TYPE),
> > +       .align = __alignof__(RTE_SECURITY_DYNFIELD_TYPE),
> > +};
> 
> Should be in rte_security.c?

Yes,
and the inline function below can be a simple macro.

> > +extern int rte_security_dynfield_offset;
> > +
> > +__rte_experimental
> > +int rte_security_dynfield_register(void);
> > +
> > +static inline RTE_SECURITY_DYNFIELD_TYPE *
> > +rte_security_dynfield(struct rte_mbuf *mbuf)
> > +{
> > +       return RTE_MBUF_DYNFIELD(mbuf,
> > +       rte_security_dynfield_offset, RTE_SECURITY_DYNFIELD_TYPE *);
> > +}