From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC713A0032; Fri, 5 Nov 2021 21:14:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C0BF40DFD; Fri, 5 Nov 2021 21:14:36 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id C1AF540151 for ; Fri, 5 Nov 2021 21:14:34 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 33B863200E79; Fri, 5 Nov 2021 16:14:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 05 Nov 2021 16:14:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= KcOY5jsLPoc+9lNQ+2Kf+VCDmqS6LzBxWlB/jLvn9I8=; b=HYvTVYsrCk1LHuNb fvxg4wZpbixWoNVVmYkjwnplXcSVeIPmNTDiSMr73s1qgk+N+sXmDLmir3JhVxMt XZwodvjbcPk6YGPWnX58P0EC5QN5qieZXgYP5Ac91fJSllfYLb27S8DBslFjEFaQ bwYVbXyKGwRI0pdjPeZcgkvi648y2taxCl40pKboIvNo4HoR3P22UkFWCA1vzMoB 1h+oZEW9/WVzXTLz7PNvUCjrK6/nqGv0O58sdedRZQS4mg5EgxZ6SCuvGce74oja CxARbY9N1sxfPA7ubn8WNOSSuLbOyJjcCseUTCFLrOjZjrxN5Wgnzm42bwghArFq vV+1qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=KcOY5jsLPoc+9lNQ+2Kf+VCDmqS6LzBxWlB/jLvn9 I8=; b=T4QYlxhQaZRIqX4vT87mCSKLZCDS+hAYWS43cR+fd1lBOPDt3xC5ZoUBR iMuIFiEQsg7/EHSjp8ur/5FsBfthDtTp3u9dTqZnfb2RVIkG39Y3FR5YOWmmOJHQ uJVfmLPXEypTlPElPDxZWW55V2WVnKeMuR82gkWXCjGr5DEZ7xYsRJ86vyXRr+zb sApgqO/+Vcv1gYYp4U6NdgGPMLvE/gLFxMLYwXzKm+LwvNGL/SfniHn/ft8D8GSp uez++mGjqMifrkNDsazOtvEk9Lp6KsLCbCv55u2R9zrMj/2srpk6W0oae7SlR/hz MlwzTdhTikg5ojc4WKj5/b46RhTyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdeigddufedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 Nov 2021 16:14:31 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , Viacheslav Galaktionov , Ferruh Yigit Cc: Ivan Malov , David Marchand , dev@dpdk.org Date: Fri, 05 Nov 2021 21:14:30 +0100 Message-ID: <2688687.HSkE7oWr40@thomas> In-Reply-To: <54c1c7a5-9093-5126-4984-c9dafa8f4cf6@intel.com> References: <20211105083333.1960017-1-andrew.rybchenko@oktetlabs.ru> <20211105083333.1960017-5-andrew.rybchenko@oktetlabs.ru> <54c1c7a5-9093-5126-4984-c9dafa8f4cf6@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/4] net/sfc: support regioned NIC DMA memory mapping type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/11/2021 20:05, Ferruh Yigit: > On 11/5/2021 8:33 AM, Andrew Rybchenko wrote: > > From: Viacheslav Galaktionov > > > > DMA on SN1022 SoC requires extra mapping of the memory via MCDI. > > The mapping is expensive on datapath, so make it a build-time option. > > Usage of build-time option is acceptable since it is required in > > very specific case only. > > > > Not really sure if it is acceptable. > > The change does not look trivial, it touches in many areas with ifdef blocks, > cluttering the code. > > Even it is in datapath, it should be possible to have another datapath > function that is only set for the specific device, even perhaps by automatically > detecting the device, not needing a compile or runtime flag. Indeed compilation option is forbidden. Function pointer is a better choice.