From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 12C1D58D3
 for <dev@dpdk.org>; Fri, 20 Jun 2014 16:28:26 +0200 (CEST)
Received: by mail-wi0-f178.google.com with SMTP id n15so905936wiw.5
 for <dev@dpdk.org>; Fri, 20 Jun 2014 07:28:39 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=pR/eA1qXm3WRTT3n1YBLaxkgZ9sDrsXpsnFv8u4zXx0=;
 b=K4qe70BbqJQY8OgY4MgdKiABzKCl2Vsbfj4IORgICIBkbsMUEZ5y15E3wiCavv5nyq
 Fi7nP31hOj60dcAVD37ENOWRwrALcKLjwYx6Df6dwNhEdveO94Ae/ANyJHSJpVF/k3px
 QiDQ3iiYEnD+/hzQ/mTvXfF5a+SHKRFbK592P84dBNJ3mzBV58X9CuOI+rjrGZzlqcE0
 Y3dn2g1pBA0/V8oi1AqisLWV8yNMfwnwyNRGaUtEY6fFLngXqlkMfxpI86qY2uL7zVF5
 6wHF/usxTc37ldtusnj79qS+lKVQoh1Pxf1S4GEnwNRBe9n0nX728s0YFyyyFp15KR9Q
 q6EQ==
X-Gm-Message-State: ALoCoQmkZGaN2nANxfH9WC7SkNv2CgMKGHTeuTrIqKN/XFC0gcbmFz/UrdslVkYqHhjB0IH1Rch1
X-Received: by 10.194.58.180 with SMTP id s20mr3916307wjq.119.1403274519490;
 Fri, 20 Jun 2014 07:28:39 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id f6sm15947583wja.25.2014.06.20.07.28.37
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 20 Jun 2014 07:28:38 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Fri, 20 Jun 2014 16:28:34 +0200
Message-ID: <2688891.cpSxDN6sGo@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <1403244889-21358-7-git-send-email-helin.zhang@intel.com>
References: <1403244889-21358-1-git-send-email-helin.zhang@intel.com>
 <1403244889-21358-7-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 6/7] i40evf: fix for copying wrong size of
	link info, and remove an useless function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jun 2014 14:28:26 -0000

2014-06-20 14:14, Helin Zhang:
> Delete the inline function which is not used at this moment.
> Fix the bug of copying wrong size of link info in function of
> i40evf_get_link_status().

There are 2 patches here. Please split.

>  static inline int
> -i40evf_dev_atomic_read_link_status(struct rte_eth_dev *dev,
> -				   struct rte_eth_link *link)
> -{
> -	struct rte_eth_link *dst = link;
> -	struct rte_eth_link *src = &(dev->data->dev_link);
> -
> -	if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
> -					*(uint64_t *)src) == 0)
> -		return -1;
> -
> -	return 0;
> -}

Not directly related to this patch, but it could be a good idea to start
using rte_eth_dev_atomic_read_link_status() instead of copying this function 
in each PMD.

-- 
Thomas