From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 43FAD1B4E4 for ; Tue, 26 Jun 2018 11:41:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 02:41:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,274,1526367600"; d="scan'208,217";a="240694554" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.44]) ([10.237.221.44]) by fmsmga006.fm.intel.com with ESMTP; 26 Jun 2018 02:41:42 -0700 To: Radu Nicolau , dev@dpdk.org Cc: chris.macnamara@intel.com, michael.j.glynn@intel.com References: <1528282041-20380-1-git-send-email-radu.nicolau@intel.com> <1528711403-29776-1-git-send-email-radu.nicolau@intel.com> <1528711403-29776-2-git-send-email-radu.nicolau@intel.com> From: "Hunt, David" Message-ID: <268d4b8d-0580-0b14-d40e-8e59ff13a73e@intel.com> Date: Tue, 26 Jun 2018 10:43:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1528711403-29776-2-git-send-email-radu.nicolau@intel.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 2/3] test/power: add unit test for get capabilities API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 09:41:44 -0000 On 11/6/2018 11:03 AM, Radu Nicolau wrote: > Signed-off-by: Radu Nicolau > --- > test/test/test_power_acpi_cpufreq.c | 42 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/test/test/test_power_acpi_cpufreq.c b/test/test/test_power_acpi_cpufreq.c > index 8da2dcc..67d5ee0 100644 > --- a/test/test/test_power_acpi_cpufreq.c > +++ b/test/test/test_power_acpi_cpufreq.c > @@ -18,6 +18,12 @@ test_power_acpi_cpufreq(void) > printf("Power management library not supported, skipping test\n"); > return TEST_SKIPPED; > } > +static int > +test_power_acpi_caps(void) > +{ > + printf("Power management library not supported, skipping test\n"); > + return TEST_SKIPPED; > +} > > #else > #include > @@ -517,6 +523,42 @@ test_power_acpi_cpufreq(void) > rte_power_unset_env(); > return -1; > } > + > +static int > +test_power_acpi_caps(void) > +{ > + struct rte_power_core_capabilities caps; > + int ret; > + > + ret = rte_power_set_env(PM_ENV_ACPI_CPUFREQ); > + if (ret) { > + printf("Error setting ACPI environment\n"); > + return -1; > + } > + > + ret = rte_power_init(TEST_POWER_LCORE_ID); > + if (ret < 0) { > + printf("Cannot initialise power management for lcore %u, this " > + "may occur if environment is not configured " > + "correctly(APCI cpufreq) or operating in another valid " > + "Power management environment\n", TEST_POWER_LCORE_ID); > + rte_power_unset_env(); > + return -1; > + } > + > + ret = rte_power_get_capabilities(TEST_POWER_LCORE_ID, &caps); > + if (ret) { > + printf("ACPI: Error getting capabilities\n"); > + return -1; > + } > + > + printf("ACPI: Capabilities %lx\n", caps.capabilities); > + > + rte_power_unset_env(); > + return 0; > +} > + > #endif > > REGISTER_TEST_COMMAND(power_acpi_cpufreq_autotest, test_power_acpi_cpufreq); > +REGISTER_TEST_COMMAND(power_acpi_caps_autotest, test_power_acpi_caps); Acked-by: David Hunt