Re: [dpdk-dev] [PATCH v6 7/8] devtools: remove check-includes script

[Thomas Monjalon <thomas@monjalon.net>]

28/01/2021 12:38, Bruce Richardson:
> On Thu, Jan 28, 2021 at 12:10:41PM +0100, Thomas Monjalon wrote:
> > 27/01/2021 18:33, Bruce Richardson:
> > > +* The ``check-includes.sh`` script for checking DPDK header files has
> > > been +  removed, being replaced by the ``check_includes`` build option
> > > described above.
> > 
> > How do they compare?  Is the new test checking C++ compliance? pedantic?
> > 
> The new support does not do either of those things - though pedantic checks
> should be fairly easy to do - so I'm ok to drop this patch and not remove
> the script.
> 
> Unfortunately, in my limited testing of it, the script has some usability
> issues now that on build all the lib includes are no longer copies to a
> single include folder.  There is no automatic detection of include paths
> for other dependent headers, which means that to run the tool on e.g.
> ethdev lib, you need to set up the CFLAGS to include the paths to the net,
> eal, kvargs, meter, etc.  libraries.  Then again, it may work well on an
> installed DPDK instance for testing, but the fact that nobody has
> complained about it being hard to use before indicates that it is not being
> used, and if it's not being used I felt it as well to just drop it.

I am OK to drop it.
My question is more about improving the new tool to reach
the initial goals of the old script.