From: Thomas Monjalon <thomas@monjalon.net>
To: matan@nvidia.com, Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org, rasland@nvidia.com,
Shahaf Shuler <shahafs@nvidia.com>,
asafp@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors
Date: Sat, 14 Nov 2020 13:06:41 +0100 [thread overview]
Message-ID: <2696445.BIzKWCxRHJ@thomas> (raw)
In-Reply-To: <20201113145231.13154-6-getelson@nvidia.com>
13/11/2020 15:52, Gregory Etelson:
> + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data->group,
> + &flow_table, grp_info, error);
The parameter grp_info is a struct passed as value.
I believe it should be passed as a pointer.
I see some other functions are passing arrays with [] syntax,
which does not make sense in parameters. I should be a simple pointer.
Matan, Slava, as maintainers, what are your policies in mlx5 code?
next prev parent reply other threads:[~2020-11-14 12:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:52 [dpdk-dev] [PATCH v2 0/5] restore tunnel offload functionality in mlx5 Gregory Etelson
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 1/5] net/mlx5: fix tunnel offload object allocation Gregory Etelson
2020-11-13 19:00 ` Thomas Monjalon
2020-11-14 17:47 ` Gregory Etelson
2020-11-14 17:55 ` Thomas Monjalon
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 2/5] net/mlx5: fix tunnel offload hub multi-thread protection Gregory Etelson
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 3/5] net/mlx5: fix double table referencing Gregory Etelson
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: fix tunnel offload callback names Gregory Etelson
2020-11-13 14:52 ` [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors Gregory Etelson
2020-11-14 12:06 ` Thomas Monjalon [this message]
2020-11-14 17:41 ` Gregory Etelson
2020-11-14 17:53 ` Thomas Monjalon
2020-11-14 18:31 ` Gregory Etelson
2020-11-14 19:24 ` Thomas Monjalon
2020-11-15 5:47 ` Gregory Etelson
2020-11-13 19:03 ` [dpdk-dev] [PATCH v2 0/5] restore tunnel offload functionality in mlx5 Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2696445.BIzKWCxRHJ@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).