From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 650ECA09E0; Sat, 14 Nov 2020 13:06:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 378DCC8C6; Sat, 14 Nov 2020 13:06:51 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 106A6C88E for ; Sat, 14 Nov 2020 13:06:48 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 8C8D2FA4; Sat, 14 Nov 2020 07:06:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 14 Nov 2020 07:06:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 2zMIgNlT8vj7yDNADhZQMT1rSA6MvSkHEkuqOCLTnps=; b=wBlB0NdgHhaM5C6V +qlsttsbCPisUN8LjESNp4rolUoRAFR9RbB+ho1mV+vjvUHML8H7I4eiffo2LTKN 1eolRq2xcWUI62T3pgsuw14d1vDI9UefR9F31oR/kPOa7NeHUyCS20OZNDqylPLr B2NDoEGYn7dtu0fvPFK5nXl+H3p8N8E47wfI7i8LsHjEnVf9bOUFQBtJw8jrV+jZ CD+T3Z+icCinXBczwW5cuOtKtkEINWfSM0KzCQwpKuCxcvcNwVLrK1S0LYrKdt8M YAzIl/6nnPGl1qTMf4LMOiZpagJ4sCt9flktcZb4t8aKHezNTMMiUj+NZNmS1Kd+ hs/gQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2zMIgNlT8vj7yDNADhZQMT1rSA6MvSkHEkuqOCLTn ps=; b=Gt19AKOf+o5WM9Rj55yy+fTVkqfJiisXiFfSgbXnWQb9G7mawDFHA0znJ 6c2q4eLoYPLBGLb1CWlYmj0oVs+TVejDj4Xthg0kARJd/iW4m0548s9xV3GhBOPn 2al7/hUrYcFviAtOVaT4Bm1Z2g/tLmmXz/pqdffuOsPntCnIanot+bCmMObd7MnG yw7z/oR8yJ+A97oISNdbB06KHQdUKACKh6g7UzgSOlnKIKv/zD14V0lkA/GUIhn3 0HaGUtc/m36Uql8wg4LwE7HlQteVF1e7jZ4h6OgalsgRLouJxAI+UTm3F0W7j/sG YjLlgwofDC34IXRxFmy1DelHnjxww== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvjedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 24411328005A; Sat, 14 Nov 2020 07:06:43 -0500 (EST) From: Thomas Monjalon To: matan@nvidia.com, Viacheslav Ovsiienko , Gregory Etelson Cc: dev@dpdk.org, rasland@nvidia.com, Shahaf Shuler , asafp@nvidia.com Date: Sat, 14 Nov 2020 13:06:41 +0100 Message-ID: <2696445.BIzKWCxRHJ@thomas> In-Reply-To: <20201113145231.13154-6-getelson@nvidia.com> References: <20201113145231.13154-1-getelson@nvidia.com> <20201113145231.13154-6-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/11/2020 15:52, Gregory Etelson: > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data->group, > + &flow_table, grp_info, error); The parameter grp_info is a struct passed as value. I believe it should be passed as a pointer. I see some other functions are passing arrays with [] syntax, which does not make sense in parameters. I should be a simple pointer. Matan, Slava, as maintainers, what are your policies in mlx5 code?