From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEA61A04C0; Tue, 29 Sep 2020 12:28:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1464B1D989; Tue, 29 Sep 2020 12:27:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 78EA31D60C for ; Tue, 29 Sep 2020 12:27:14 +0200 (CEST) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601375233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Xjubo84FM5BiXxbmb6EkwvPnnxgJ/ei4P1+otDNW1Z4=; b=gVyq24WVjblD+Ukb78DtPMHxtz5diAVmz2RHgUx3RWffg6aymsyl80+N0Yt+YLWLOXjbOW Cpa9AUeRulU9Ff94cztFL/8Gtk55GZWn1E9Whmms0VQESNklFvyYON1OIQVXRvSMgEOljB BwogRSIaJd656pWUAyeYf6nQ4VXgSXA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-I8NyKKo2MVu0flpgthj-eQ-1; Tue, 29 Sep 2020 06:27:10 -0400 X-MC-Unique: I8NyKKo2MVu0flpgthj-eQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2FA35802B4E; Tue, 29 Sep 2020 10:27:05 +0000 (UTC) Received: from [10.36.110.36] (unknown [10.36.110.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CA2B5578B; Tue, 29 Sep 2020 10:26:51 +0000 (UTC) To: Thomas Monjalon , dev@dpdk.org Cc: ferruh.yigit@intel.com, arybchenko@solarflare.com, Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Hemant Agrawal , Sachin Saxena , Jeff Guo , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Shijith Thotton , Srisivasubramanian Srinivasan , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Harman Kalra , Rasesh Mody , Shahed Shaikh , Keith Wiles , Chenbo Xia , Zhihong Wang , Yong Wang References: <20200913220711.3768597-1-thomas@monjalon.net> <20200928231437.414489-1-thomas@monjalon.net> <20200928231437.414489-29-thomas@monjalon.net> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <269736e1-bf3f-a010-914f-904f86e8c947@redhat.com> Date: Tue, 29 Sep 2020 12:26:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200928231437.414489-29-thomas@monjalon.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 28/29] ethdev: reset all when releasing a port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/20 1:14 AM, Thomas Monjalon wrote: > The function rte_eth_dev_release_port() was resetting partially > the struct rte_eth_dev. The drivers were completing it > with more pointers set to NULL in the close or remove operations. > > A full memset is done so most of those assignments become useless. > > Signed-off-by: Thomas Monjalon > --- > drivers/net/ark/ark_ethdev.c | 3 --- > drivers/net/atlantic/atl_ethdev.c | 4 ---- > drivers/net/axgbe/axgbe_ethdev.c | 3 --- > drivers/net/bnxt/bnxt_ethdev.c | 4 ---- > drivers/net/bnxt/bnxt_reps.c | 1 - > drivers/net/bonding/rte_eth_bond_pmd.c | 4 ---- > drivers/net/dpaa/dpaa_ethdev.c | 4 ---- > drivers/net/dpaa2/dpaa2_ethdev.c | 4 ---- > drivers/net/e1000/em_ethdev.c | 4 ---- > drivers/net/e1000/igb_ethdev.c | 8 -------- > drivers/net/ena/ena_ethdev.c | 5 ----- > drivers/net/fm10k/fm10k_ethdev.c | 4 ---- > drivers/net/hinic/hinic_pmd_ethdev.c | 4 ---- > drivers/net/hns3/hns3_ethdev.c | 4 ---- > drivers/net/hns3/hns3_ethdev_vf.c | 5 ----- > drivers/net/i40e/i40e_ethdev.c | 4 ---- > drivers/net/i40e/i40e_ethdev_vf.c | 4 ---- > drivers/net/iavf/iavf_ethdev.c | 4 ---- > drivers/net/ice/ice_dcf_ethdev.c | 4 ---- > drivers/net/ice/ice_ethdev.c | 4 ---- > drivers/net/ionic/ionic_ethdev.c | 5 ----- > drivers/net/ixgbe/ixgbe_ethdev.c | 8 -------- > drivers/net/liquidio/lio_ethdev.c | 4 ---- > drivers/net/netvsc/hn_ethdev.c | 4 ---- > drivers/net/octeontx/octeontx_ethdev.c | 3 --- > drivers/net/qede/qede_ethdev.c | 4 ---- > drivers/net/sfc/sfc_ethdev.c | 7 +------ > drivers/net/tap/rte_eth_tap.c | 1 - > drivers/net/virtio/virtio_ethdev.c | 4 ---- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 ----- > lib/librte_ethdev/rte_ethdev.c | 5 +---- > 31 files changed, 2 insertions(+), 129 deletions(-) With this patch, I get following segfault at init time with Virtio PMD: Program received signal SIGSEGV, Segmentation fault. 0x0000000000854c9b in rte_eth_dev_callback_register (port_id=32, event=RTE_ETH_EVENT_UNKNOWN, cb_fn=0x4b24de , cb_arg=0x0) at ../lib/librte_ethdev/rte_ethdev.c:4042 4042 TAILQ_INSERT_TAIL(&(dev->link_intr_cbs), (gdb) bt full #0 0x0000000000854c9b in rte_eth_dev_callback_register (port_id=32, event=RTE_ETH_EVENT_UNKNOWN, cb_fn=0x4b24de , cb_arg=0x0) at ../lib/librte_ethdev/rte_ethdev.c:4042 dev = 0x2fe9980 user_cb = 0x1003b0300 next_port = 0 last_port = 31 #1 0x00000000004b268f in register_eth_event_callback () at ../app/test-pmd/testpmd.c:3111 ret = 0 event = RTE_ETH_EVENT_UNKNOWN #2 0x00000000004b3a7e in main (argc=2, argv=0x7fffffffeb18) at ../app/test-pmd/testpmd.c:3658 diag = 0 port_id = 0 count = 0 ret = -5584 (gdb) l 4042 4037 sizeof(struct rte_eth_dev_callback), 0); 4038 if (user_cb != NULL) { 4039 user_cb->cb_fn = cb_fn; 4040 user_cb->cb_arg = cb_arg; 4041 user_cb->event = event; 4042 TAILQ_INSERT_TAIL(&(dev->link_intr_cbs), 4043 user_cb, next); 4044 } else { 4045 rte_spinlock_unlock(&rte_eth_dev_cb_lock); 4046 rte_eth_dev_callback_unregister(port_id, event, (gdb) p rte_eth_devices[0] $2 = { rx_pkt_burst = 0x0, tx_pkt_burst = 0x0, tx_pkt_prepare = 0x0, rx_queue_count = 0x0, rx_descriptor_done = 0x1589664 , rx_descriptor_status = 0x0, tx_descriptor_status = 0x0, data = 0x1003b3700, process_private = 0x0, dev_ops = 0x29621a0 , device = 0x3174dc0, intr_handle = 0x3174ea0, link_intr_cbs = { tqh_first = 0x0, tqh_last = 0x0 }, post_rx_burst_cbs = {0x0 }, pre_tx_burst_cbs = {0x0 }, state = RTE_ETH_DEV_ATTACHED, security_ctx = 0x0, reserved_64s = {0, 0, 0, 0}, reserved_ptrs = {0x0, 0x0, 0x0, 0x0} } When reverted, it looks OK. Thanks, Maxime