DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Gaurav Singh <gaurav1086@gmail.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bxnt: remove redundant null check
Date: Wed, 05 Aug 2020 22:11:39 +0200
Message-ID: <26979354.Z9mb2dG3pe@thomas> (raw)
In-Reply-To: <CACZ4nhthbvL-qnZBstRj0Ri=3QOq95M_gC0F0+95V=GopOu0GQ@mail.gmail.com>

31/07/2020 07:03, Ajit Khaparde:
> On Thu, Jul 30, 2020 at 7:35 PM Gaurav Singh <gaurav1086@gmail.com> wrote:
> 
> > vxlan_mask cannot be NULL since its already being accessed
> > before. Remove the redundant NULL check.

Do you mean vxlan_spec?

> > Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
> >
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

The title has a typo: bxnt

> >                         /* Check if VNI is masked. */
> > -                       if (vxlan_spec && vxlan_mask) {
> > +                       if (vxlan_mask) {

This kind of implicit check is against the coding style.
Except for boolean variables, we should use == or !=

Ajit, please check details when reviewing, thanks.




  reply	other threads:[~2020-08-05 20:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31  2:34 Gaurav Singh
2020-07-31  5:03 ` Ajit Khaparde
2020-08-05 20:11   ` Thomas Monjalon [this message]
2020-08-06  3:50     ` [dpdk-dev] [PATCH] net/bnxt: remove redundant null check in bnxt_validate_and_parse_flow_type Gaurav Singh
2020-08-06  3:52 ` Gaurav Singh
2020-09-02  4:03   ` Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26979354.Z9mb2dG3pe@thomas \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=gaurav1086@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git