From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB6CEA053A; Wed, 5 Aug 2020 22:11:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB1D72C23; Wed, 5 Aug 2020 22:11:45 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 33F8A2BF2 for ; Wed, 5 Aug 2020 22:11:44 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 19A655EC; Wed, 5 Aug 2020 16:11:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 16:11:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Idb2f8ayp6jk2AtLVX35Z5KKRq3B3aaByBp4ysrgLTE=; b=i0eWxbhKKTA5Rvwj C+oAVPrlX6u0gNQmY/Fe1fk7rVZM3HxPzIkMWQoCpQ6xzlvIXmvsW88bf0dEG+9G 6Y3jSQRxl5MfQiNh/PMTnR/MRGcVI5sv/VtQilnTC4u6yGtTK4PDWDzQSdZpkbHJ DWii3zk6CogFXW3gYE3KiqeqH2Vj9NWD6zJtH9Aod2JwgmELB7TOyL9FbOZlppjw Avr3cwd1GflJsft7MNHaRq4f0PzmVfX/DtC4Z8OjDUwL2WJQhXGsI9hRgY++sjAH Ta3vCpVw4KgbfOjil0pskjmNW753yWjPGV2qBJx8NElfAYFDSKS8XDUartU+15oB 0UqahA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Idb2f8ayp6jk2AtLVX35Z5KKRq3B3aaByBp4ysrgL TE=; b=TbNTGlWlaz6i8gIAkFMeSkuVmT7+O9h71HmesQiE9IByRbet8MfzL7OrD 2eymwzfSne9vI+8cFCGDYz2plT6IRf67r8lfHjHTf9oRmfCI3KoICIf63i8KepwQ Kfkmu0SnP2Zv5v9bq8tfUFdjJWX8S+Mw8vMVtlN3J3xubl41cbReqOKUS06nJuxG Ggzc/o0wiiAtWGwM3f7LqSHLCHBYnLBnzn1A8PREA19nfAZh2nJ51THetpx0lp79 MECVkTNbSxwy08YDo9ObKIrx6i3pITgYqzc9PlWezBoL1dILLPcyn6t3NNzv9SEH 911qCRsP/KSuRPQf5Yk61W5fVNwWg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 02246328005A; Wed, 5 Aug 2020 16:11:41 -0400 (EDT) From: Thomas Monjalon To: Gaurav Singh , Ajit Khaparde Cc: dev@dpdk.org Date: Wed, 05 Aug 2020 22:11:39 +0200 Message-ID: <26979354.Z9mb2dG3pe@thomas> In-Reply-To: References: <20200731023444.27986-1-gaurav1086@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/bxnt: remove redundant null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 31/07/2020 07:03, Ajit Khaparde: > On Thu, Jul 30, 2020 at 7:35 PM Gaurav Singh wrote: > > > vxlan_mask cannot be NULL since its already being accessed > > before. Remove the redundant NULL check. Do you mean vxlan_spec? > > Signed-off-by: Gaurav Singh > > > Acked-by: Ajit Khaparde The title has a typo: bxnt > > /* Check if VNI is masked. */ > > - if (vxlan_spec && vxlan_mask) { > > + if (vxlan_mask) { This kind of implicit check is against the coding style. Except for boolean variables, we should use == or != Ajit, please check details when reviewing, thanks.