From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86F9841C97; Tue, 14 Feb 2023 19:51:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FF5841144; Tue, 14 Feb 2023 19:51:00 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2052.outbound.protection.outlook.com [40.107.243.52]) by mails.dpdk.org (Postfix) with ESMTP id 2B6F740EE4; Tue, 14 Feb 2023 19:50:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1u9MuVRcfl6ufSHl2hCvlELxBsIlCrHj2gdYaOoNOaV1ZLIyCdpEj4wtWwhzPF6IXtL6PVFgaFYSMs2xW1r3odVZliPkbvwhlovouUa4wAhiiFfyCp444kSruQJvjnGiJ4OkUmX1S/QJOo+KmfaRSBaS2X3uc/WkWoi96dSqvOAa7Bv5Wl5y4A6tFfj9YI52MRPvNnrBkajWDy5Lm+vwZsjaUTCNPX4Nr/z43vitkUqfnuDodrvTHjmSZFhvAbS0kceLM+LQlkeej4bA+k6nP1BFZEs8cDZbYOW83U0QIh19MlBDyiU0iS31tBr3mzDh1ZmAoVrOs5NPHuzdKa9Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nHtbFP8zkYQZ57CPM5qW8EeZzXIE/lWKfxmsWJ39O7w=; b=D8Bxu0/+NEV9rntGD3w7U9Whfjuuy4x9tq0Kwx8taBftEax/EotYjoOI7+r3F/gF92OplmB3AyvkKT2zDYDi8lAKFC74k89LgtTP0/AzvjSlQZz7qt2wzC15hTmfH+2dL3Pprnh7TCSlOeyi++OgsCJrWJ62QLHsxFLnncW3IkOK8pyRFzdHt5YNg01Ch/J3Ep/62mFQlrc2gmo05/d35/MknK5tfG3UIOzWI58R+dLSgsCmhUXWnj2gll+Szqb4X/77HAMYXKtThKDjGyGkJwZ5tWShORgJiRnYVAlUBNH4My2pSAVSaOBw1tvmbzLV/f/GixHXqkzTBjU7PHZwjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHtbFP8zkYQZ57CPM5qW8EeZzXIE/lWKfxmsWJ39O7w=; b=gLKJae1F/fwJcOZFx45ANfscKOg9ft26TYyrTcmaIlUDUvZkS77cYR/E9WAazAdJc5+i7LU9Q4SQS4FWo2D9bLIUfwhkT1ALTNe3H94cq7ny80GRAPzVD9vIb/+GFE/2D3EHkgG2XrrNuXh9Fd3wzDrAddZDbwfJ+MaFPDmCtKI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB5768.namprd12.prod.outlook.com (2603:10b6:8:77::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Tue, 14 Feb 2023 18:50:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.026; Tue, 14 Feb 2023 18:50:55 +0000 Message-ID: <26c34036-04c3-051c-1633-4c96620bf746@amd.com> Date: Tue, 14 Feb 2023 18:50:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] net/sfc: fix MAC address entry leak in transfer flow parsing Content-Language: en-US To: Andrew Rybchenko , Ivan Malov , dev@dpdk.org Cc: stable@dpdk.org, Viacheslav Galaktionov , Andy Moreton References: <20230214130659.6971-1-ivan.malov@arknetworks.am> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0489.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB5768:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e1fd13a-b54f-4b37-c657-08db0ebc676a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HXPHC7OogRlFFs+yem/+F/qGYv6i2NMTo1Qj5VbfYkUGKYtk7YIMaTDFG92lshFGtOtnvbUR+XQRxHHCIlIqzznZOMIs9CiNSVnzceC9HYD2GYLEqRee9Ye4bM3jpmhx31p/ACNQHAkD7YyACgxFGFLn8kx5P0pNXllN3/dZoM2iKE1CGZl7wN7UH0FO8/K2JNfer5M9H9zVCweHlSeH3ZPxpGuuZZGwW1Ok5kPl2I6CoNdU1O5KkO8q5NZPa//PB42A0dOSFzjba7ZJzIQ8UI+qJhvFhOZbFp2ULtT8ezAV6OTwXrW6S9jHS9jEDlhyOFoXL/8AXAOE3wu/btqVCL0/RhEH8scCYin0NsOkoEh0hMMlXyInyrEADycPS/XzYehD2Jzo1ig0fxcsaPA2VxcpRXFUCBKtSzJUjkDjOmoobT6X9z7Ase0YAWoqj1vVgqSXvQXgWHvcwjB5AIjqbmWN0bRqUSO6dq1Cfr9GSyb7t5MliVKDH4255Mhx0f/1j1jcUPmGWmaGA5I79jykYRUwxF6spoC2Rt02674QySitpgw2WL/7EPkW84wunG/U9Ecgy9XlYAwsusABxYiBPrmtOtuyauHo2tQMc+hiteCgfpTfJg/Zs9+UusJ+qKOktfklxFxSMg6+EIhnm9sn4iZeyeVNAXsdtrRMk+cKXPFoAvtRpMLMsR45+HokclOdAQXrDWxf4OqYc23nlOcCtC4r1hoMjlVe/X2ZjoAqauI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(136003)(346002)(366004)(396003)(39860400002)(451199018)(2616005)(86362001)(6666004)(4326008)(8676002)(66946007)(66476007)(31696002)(66556008)(478600001)(36756003)(6486002)(316002)(83380400001)(54906003)(110136005)(5660300002)(4744005)(31686004)(44832011)(186003)(6512007)(26005)(2906002)(41300700001)(6506007)(8936002)(53546011)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWxHQTcvTEFnNkRTNnNJMXlMSlU3L2VKMFVaSzUwc09Eb2xNbFU4YytCc2ww?= =?utf-8?B?RHZwSWd5YWFuSVhJSFZaeTFXbk51VzJzc09WVUc3MmhCV2piQ2J3dGRSR1o2?= =?utf-8?B?UDBuSFpZNWxRbnFSZUxJLzdpN2hGelIwaENxMjJ3aUhGbkd2R2hpUjlVQ24r?= =?utf-8?B?MVZXQ0IzTFhoWVdPNEpYYlJWLy9IZjJlVWsxWHJraGhmUFpSekpIL2xWTjZ4?= =?utf-8?B?Zk5odUduR29LenJTWEZqYlEzUE1CMisweFJscTUyQ0JmWTd2b3pLRm8yQ2Fo?= =?utf-8?B?ODFjRHVtcHZzbHMxRHEvcXJYeDlHTUNvanpwMHVveDNNTnFoak1hU2E3SW5X?= =?utf-8?B?N0xrTDdnQTlSZG1Ec1JxNGIyWkRTdElWaHA2VnluSnhJbTE4bDV3dUlmUWNI?= =?utf-8?B?YUQzVTlEZGFNU0tTckRobUhqYklTbDd2Yml4THk3bEVDeDMzZmdvNG5iK1VJ?= =?utf-8?B?MEh4cUk0L1lhNFZEWXpBZXQ4WVRhZllNOTEyR2tOVzdtR0N1S29PdmR1SU9S?= =?utf-8?B?aHpoQ2tISW1kdlZWSjJQREJGV2Foc3VHRjRnWGRjOU8zM2JIMmVrYmxrdkZP?= =?utf-8?B?aGFsN2pKQzd4Wjk2VDRlbzlDcFFaOHFjMXhadGJUSm00cmVFNWphK0dlZlVQ?= =?utf-8?B?RmQ0VE9jeXpmRG5zZWhnNDRwK3dsWUhiL3prYW56REtPenNUaXRhTGxKWFov?= =?utf-8?B?SmU2YmNwRXZDWDk2R0VQck9mZFpWRll3c2dtUWFIWk9sOVltc2VnbWZBczJH?= =?utf-8?B?UU01d0JrSXlnMnVySGtwRVV1NHpINGFEUzdtVGtEdHU2dEFEMlhOanFDSFo5?= =?utf-8?B?QWlXRXBQTmU3M1Bha2sxU1NGQmh2TGtSWTcrSitQcDRXVmhzUjBCTGpnVnYy?= =?utf-8?B?OThNVHpkUGE0RHN6bHd6WnVVK3lDZHk2NVVBNzM2dHJvMDFobTZLTnJGWHMy?= =?utf-8?B?VGVMdkpGbUJkZDJQakRzQlhyYXVZUnBPWGRlRzdrRWlJbGhWMTBsamt6aXRP?= =?utf-8?B?a2EzWTdyVTN6OHhweVBkVmk1UTJ5MGxwcUxUWStiZXNNS3dzYy9TYmdkdWpx?= =?utf-8?B?Y1l2SkRmRndBMldDYjVwV0NUSVRTZDBGVm4yb0grNkZhZmZCZzFxQUUwWi9L?= =?utf-8?B?ZFhLRTZpMUFBMXprZXFKTHdjR1kwWUM4K1p0SVdzVDg0Uk9wT1N3YTlqKzFN?= =?utf-8?B?bkVyN3I4eG9obmlnUlc0TGF3Ykt5WE5PSnQrWTFVWSszYmlqMHR4ZUtWd0pD?= =?utf-8?B?QmZsT1piS01Va2RPSEp3RUdkRmZUcVYzWGw1YW5nRU1EcmZ5a0pnZkhsaUhH?= =?utf-8?B?aTgwUllzdGxLVkxHQ1gzT2NiRU5tTlpCc2pTa0FPUUprYk1FSE80VmhCVnVu?= =?utf-8?B?UlUyclZOUTREZ1lCWjNWVnlkR3VyZVRDOFNDcnJ3RVlNVDNqb3hKQmYvWThW?= =?utf-8?B?cXRYYzJSOVE3YjZEbEphcFdhL3kyK2ZGZXhtNzN2ckxKTVhveGdKYXcxNG1I?= =?utf-8?B?QTRSU3JNand3N0JQRmtaaWppc0x6S2Q4clpOaHlORXRvc0hUVXFyT0V0UmRn?= =?utf-8?B?RlhIcjdFc01TUUJJaDNFT29oQ1dwNnJacFp4RjgwOHkzNm5RZW1zdlNicHZC?= =?utf-8?B?cFJpS2JFMllZN2hQQ1k4eFpxMG5DeWs0RTFRTVJiMEJCOE5oU1MrRFVqeVJr?= =?utf-8?B?UEJvTUNUZklLVHU5cVVPSlo2QVVzK0ZIZExkL0w4VEZqdXVGeks3VHB1WTdt?= =?utf-8?B?aXRhWFRGUy9ZVDJKRTBPbXZhQnAvYWdZVnFWWmdsR1g5OHJCalFoclk4V3NU?= =?utf-8?B?QTR2aloxeUNYc2xYaDEzWXRuWEl3NldJVEN5MFJwV0F6U3VzRHhRWTRqMnA5?= =?utf-8?B?K1MycmRIK0NsSVJYZitKeEl6bE4rblpmWDRMaEdjQWFjVFJlN1Azc0dJRjJ2?= =?utf-8?B?eFNhK1NuMWFMN3dKNTFaK05nbDJob284VkQ1VkRHblVYdkxLWDlMbnZCMmRy?= =?utf-8?B?SGNhTE5icUhLNzZFYW8wblI3SStyMHlGRksvVTdqS2RQSisrMkFUU0NCcEtu?= =?utf-8?B?aUdwSmR2d0hTODEva1l6YkxoQWxKYWFwZDIwQmZwdzd5OHpKWk1IdXdGZlJM?= =?utf-8?Q?A/9rLHVuj5bjeMLL7GQjArsQa?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e1fd13a-b54f-4b37-c657-08db0ebc676a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 18:50:55.7248 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +P4sg7TVH1eCH3F8aANdQfKW4c3NznzjiQ6Lc5UX0X3krpEPrqRKvqiaySpInhua X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5768 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/14/2023 1:41 PM, Andrew Rybchenko wrote: > On 2/14/23 16:06, Ivan Malov wrote: >> When the action parsing helper discovers it can "attach" to >> an existing action set, it must invoke "delete" on the MAC >> address(es) that it has "attached" to during parsing. That >> is because the action set itself (i.e. not the flow rule >> entry) holds a reference of the address(es). >> >> Fixes: 4c6005999e41 ("net/sfc: support MAC address edits in transfer >> flows") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ivan Malov >> Reviewed-by: Viacheslav Galaktionov >> >> Reviewed-by: Andy Moreton > > Acked-by: Andrew Rybchenko > > Applied to dpdk-next-net/main, thanks.