From: "Kinsella, Ray" <mdr@ashroe.eu>
To: "Guo, Jia" <jia.guo@intel.com>,
David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "arybchenko@solarflare.com" <arybchenko@solarflare.com>,
Neil Horman <nhorman@tuxdriver.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
Jianfeng Tan <jianfeng.tan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 5/6] eal: hide internal device event structure
Date: Fri, 18 Sep 2020 14:36:46 +0100 [thread overview]
Message-ID: <26c96a9c-9074-6caa-ac94-a6c9eb6bbc32@ashroe.eu> (raw)
In-Reply-To: <cd398680b67f461294fb14ea1338fba5@intel.com>
On 18/09/2020 04:40, Guo, Jia wrote:
> Hi, David
>
>> -----Original Message-----
>> From: David Marchand <david.marchand@redhat.com>
>> Sent: Thursday, September 17, 2020 7:28 PM
>> To: dev@dpdk.org
>> Cc: arybchenko@solarflare.com; Ray Kinsella <mdr@ashroe.eu>; Neil
>> Horman <nhorman@tuxdriver.com>; Mcnamara, John
>> <john.mcnamara@intel.com>; Kovacevic, Marko
>> <marko.kovacevic@intel.com>; Jianfeng Tan <jianfeng.tan@intel.com>; Guo,
>> Jia <jia.guo@intel.com>
>> Subject: [PATCH v3 5/6] eal: hide internal device event structure
>>
>> This structure is not used in the public API.
>>
>> Fixes: a753e53d517b ("eal: add device event monitor framework")
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Agree with the patch that the struct involve os platform specific, it is better no public it.
> Acked-by: Jeff Guo <jia.guo@intel.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 3 ---
>> doc/guides/rel_notes/release_20_11.rst | 3 +++
>> lib/librte_eal/include/rte_dev.h | 6 ------
>> lib/librte_eal/linux/eal_dev.c | 6 ++++++
>> 4 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index 8fca461045..3669d6533b 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -70,9 +70,6 @@ Deprecation Notices
>> * eal: The function ``rte_eal_remote_launch`` will return new error codes
>> after read or write error on the pipe, instead of calling ``rte_panic``.
>>
>> -* eal: The ``rte_dev_event`` structure will be made private to the EAL as no
>> - public API makes use of it.
>> -
>> * rte_atomicNN_xxx: These APIs do not take memory order parameter. This
>> does
>> not allow for writing optimized code for all the CPU architectures supported
>> in DPDK. DPDK will adopt C11 atomic operations semantics and provide
>> wrappers diff --git a/doc/guides/rel_notes/release_20_11.rst
>> b/doc/guides/rel_notes/release_20_11.rst
>> index 185eeae731..e87509dfa7 100644
>> --- a/doc/guides/rel_notes/release_20_11.rst
>> +++ b/doc/guides/rel_notes/release_20_11.rst
>> @@ -87,6 +87,9 @@ API Changes
>> * eal: The ``rte_logs`` struct and global symbol was made private
>> and is no longer part of the API.
>>
>> +* eal: Made the ``rte_dev_event`` structure private to the EAL as no
>> +public API
>> + used it.
>> +
>> * pci: Removed the ``rte_kernel_driver`` enum defined in rte_dev.h and
>> replaced with a private enum in the PCI subsystem.
>>
>> diff --git a/lib/librte_eal/include/rte_dev.h
>> b/lib/librte_eal/include/rte_dev.h
>> index 53c8bc6fab..81905b3ae3 100644
>> --- a/lib/librte_eal/include/rte_dev.h
>> +++ b/lib/librte_eal/include/rte_dev.h
>> @@ -33,12 +33,6 @@ enum rte_dev_event_type {
>> RTE_DEV_EVENT_MAX /**< max value of this enum */
>> };
>>
>> -struct rte_dev_event {
>> - enum rte_dev_event_type type; /**< device event type */
>> - int subsystem; /**< subsystem id */
>> - char *devname; /**< device name */
>> -};
>> -
>> typedef void (*rte_dev_event_cb_fn)(const char *device_name,
>> enum rte_dev_event_type event,
>> void *cb_arg);
>> diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c
>> index 83b6068264..2e15762b56 100644
>> --- a/lib/librte_eal/linux/eal_dev.c
>> +++ b/lib/librte_eal/linux/eal_dev.c
>> @@ -133,6 +133,12 @@ dev_uev_socket_fd_create(void)
>> return ret;
>> }
>>
>> +struct rte_dev_event {
>> + enum rte_dev_event_type type; /**< device event type */
>> + int subsystem; /**< subsystem id */
>> + char *devname; /**< device name */
>> +};
>> +
>> static int
>> dev_uev_parse(const char *buf, struct rte_dev_event *event, int length) {
>> --
>> 2.23.0
>
next prev parent reply other threads:[~2020-09-18 13:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 8:17 [dpdk-dev] [PATCH 0/5] 20.11 announced cleanups David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 1/5] bus/pci: switch to private kernel driver enum David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 2/5] pci: move resource mapping to the PCI bus David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 3/5] mem: drop mapping API workaround David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 4/5] eal: hide internal device event structure David Marchand
2020-09-14 8:17 ` [dpdk-dev] [PATCH 5/5] bus/pci: remove duplicate declaration David Marchand
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 0/6] 20.11 announced cleanups David Marchand
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 1/6] ethdev: remove unused kernel driver field David Marchand
2020-09-14 10:14 ` Andrew Rybchenko
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 2/6] bus/pci: switch to private kernel driver enum David Marchand
2020-09-14 10:19 ` Andrew Rybchenko
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 3/6] pci: move resource mapping to the PCI bus David Marchand
2020-09-14 10:22 ` Andrew Rybchenko
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 4/6] mem: drop mapping API workaround David Marchand
2020-09-14 10:22 ` Andrew Rybchenko
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 5/6] eal: hide internal device event structure David Marchand
2020-09-18 14:56 ` Kinsella, Ray
2020-09-14 8:23 ` [dpdk-dev] [PATCH v2 6/6] bus/pci: remove duplicate declaration David Marchand
2020-09-14 10:24 ` Andrew Rybchenko
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 0/6] 20.11 announced cleanups David Marchand
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 1/6] ethdev: remove unused kernel driver field David Marchand
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 2/6] bus/pci: switch to private kernel driver enum David Marchand
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 3/6] pci: move resource mapping to the PCI bus David Marchand
2020-09-18 13:43 ` Kinsella, Ray
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 4/6] mem: drop mapping API workaround David Marchand
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 5/6] eal: hide internal device event structure David Marchand
2020-09-18 3:40 ` Guo, Jia
2020-09-18 13:36 ` Kinsella, Ray [this message]
2020-09-17 11:28 ` [dpdk-dev] [PATCH v3 6/6] bus/pci: remove duplicate declaration David Marchand
2020-09-21 9:05 ` [dpdk-dev] [PATCH v3 0/6] 20.11 announced cleanups David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26c96a9c-9074-6caa-ac94-a6c9eb6bbc32@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).