From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E13A041BB9; Fri, 3 Feb 2023 08:04:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB0D74067B; Fri, 3 Feb 2023 08:04:48 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id CFE334014F for ; Fri, 3 Feb 2023 08:04:47 +0100 (CET) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P7RRn0kZLzRrn0; Fri, 3 Feb 2023 15:02:29 +0800 (CST) Received: from [10.67.103.42] (10.67.103.42) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 3 Feb 2023 15:04:44 +0800 Message-ID: <26d342bf-3621-17dd-2f28-a0a7e08653df@huawei.com> Date: Fri, 3 Feb 2023 15:04:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 2/2] ring: add ring info telemetry cmd To: Honnappa Nagarahalli , "konstantin.v.ananyev@yandex.ru" , "dev@dpdk.org" CC: "liudongdong3@huawei.com" , nd , Huisong Li , , haijie References: <20230117130333.8707-1-haijie1@huawei.com> <20230131022841.10775-1-haijie1@huawei.com> <20230131022841.10775-3-haijie1@huawei.com> From: Jie Hai In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.42] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/2/1 0:44, Honnappa Nagarahalli wrote: > Few minor nits. Otherwise, > > Reviewed-by: Honnappa Nagarahalli > Thanks for your review. >> -----Original Message----- >> From: Jie Hai >> Sent: Monday, January 30, 2023 8:29 PM >> To: Honnappa Nagarahalli ; >> konstantin.v.ananyev@yandex.ru; dev@dpdk.org >> Cc: liudongdong3@huawei.com; haijie1@huawei.com >> Subject: [PATCH v3 2/2] ring: add ring info telemetry cmd > "ring: add telemetry cmd for ring info" >> >> This patch supports dump of the info of ring by its name. > This patch supports dump of ring information by its name. > Accepted and will change it in v4. >> An example using this command is shown below: >> >> --> /ring/info,MP_mb_pool_0 >> { >> "/ring/info": { >> "name": "MP_mb_pool_0", >> "socket": 0, >> "flags": 0, >> "producer_type": "MP", >> "consumer_type": "MC", >> "size": 262144, >> "mask": 262143, >> "capacity": 262143, >> "used_count": 147173, >> "consumer_tail": 8283, >> "consumer_head": 8283, >> "producer_tail": 155456, >> "producer_head": 155456, > Sometimes it is much easier to understand these numbers if they are in hexadecimal. Is it possible to add the hexadecimal format in brackets? Something like: > "size": 262144 (0x40000) > Huisong Li makes it possible in http://patches.dpdk.org/project/dpdk/patch/20221219070648.33817-7-lihuisong@huawei.com/. We can change rte_tel_data_add_dict_u64 to rte_tel_data_add_dict_uint_hex after his patch accepted. >> -- >> 2.33.0 > > .