From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by dpdk.org (Postfix) with ESMTP id 127FB1B199 for ; Thu, 30 Nov 2017 23:27:29 +0100 (CET) Received: from WTL-EXCHSV2-2.sandvine.com (192.168.194.59) by WTL-EXCHSV2-2.sandvine.com (192.168.194.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P521) id 15.1.1034.26; Thu, 30 Nov 2017 17:27:28 -0500 Received: from WTL-EXCHSV2-2.sandvine.com ([fe80::70e5:d09e:7bb9:986a]) by WTL-EXCHSV2-2.sandvine.com ([fe80::70e5:d09e:7bb9:986a%20]) with mapi id 15.01.1034.026; Thu, 30 Nov 2017 17:27:28 -0500 From: Kyle Larose To: Jianfeng Tan , "dev@dpdk.org" CC: Matthew Coppola Thread-Topic: [dpdk-dev] [PATCH] bus/vdev: scan and probe vdev in secondary processes Thread-Index: AQHTag1J/UnOOcGvuEOEiSGO019TkKMtfvPg Date: Thu, 30 Nov 2017 22:27:28 +0000 Message-ID: <26d38eefe9814bfcb29b058b8922dc8c@sandvine.com> References: <1512068332-98288-1-git-send-email-jianfeng.tan@intel.com> In-Reply-To: <1512068332-98288-1-git-send-email-jianfeng.tan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.200.51] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] bus/vdev: scan and probe vdev in secondary processes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 22:27:30 -0000 Hey Jianfeng, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jianfeng Tan > Sent: Thursday, November 30, 2017 1:59 PM > To: dev@dpdk.org > Cc: Jianfeng Tan > Subject: [dpdk-dev] [PATCH] bus/vdev: scan and probe vdev in > secondary processes >=20 > Base on primary/secondary communication channel [1], we add vdev > action to scan virtual devices in secondary processes. >=20 > [1] http://dpdk.org/dev/patchwork/patch/31838/ >=20 > Signed-off-by: Jianfeng Tan > --- > drivers/bus/vdev/vdev.c | 104 > ++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 100 insertions(+), 4 deletions(-) >=20 We recently stumbled across a problem where running dpdk-pdump against a primary which had an rte_eth_bond virtual device would lead to a crash. We realized this was happening because the vdev bus wasn't being built properly on the secondary, leading to it corrupting the ethdev structures for the eth_bond device on the primary. This corruption occurred because pd= ump used what it thought was the first free dpdk port id for its pcap_pmd. That= =20 port id collided with the eth_bond pmd, causing the problem. My feeling is that this patch will fix that problem, since probing the virt= ual bus from the primary, rather than just from the eal cmdline arguments, will= =20 allow the secondary to choose an used port id. Am I correct in my understan= ding? Thanks, Kyle