From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Huang, ZhiminX" <zhiminx.huang@intel.com>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF
Date: Mon, 22 Feb 2021 12:39:52 +0000 [thread overview]
Message-ID: <26d6917370594a63b0497f4265e16169@intel.com> (raw)
In-Reply-To: <d389a8557c82466e8375ce6db7cc3548@intel.com>
> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: Friday, February 19, 2021 5:06 PM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF
>
> Tested-by: Huang, ZhiminX <zhiminx.huang@intel.com>
>
> Regards,
> HuangZhiMin
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Alvin Zhang
> > Sent: Friday, February 19, 2021 1:14 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> > stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF
> >
> > The macro flag DEV_RX_OFFLOAD_VLAN_FILTER is used to enable/disable Rx
> > VLAN filter, but not Tx VLAN filter. Therefore, Tx VLAN filter should
> > not be enabled/disabled in function ice_vsi_config_vlan_filter called
> > after checking DEV_RX_OFFLOAD_VLAN_FILTER flag.
> >
> > In addition, the kernel driver doesn't enable/disable the TX VLAN
> > filter in the similar function ice_cfg_vlan_pruning.
> >
> > This patch removes the setting about the TX VLAN filter in function
> > ice_vsi_config_vlan_filter.
> >
> > Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2021-02-22 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 5:07 Alvin Zhang
2021-02-19 5:13 ` Alvin Zhang
2021-02-19 9:06 ` Huang, ZhiminX
2021-02-22 12:39 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26d6917370594a63b0497f4265e16169@intel.com \
--to=qi.z.zhang@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=zhiminx.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).