From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1ABC6A00C5;
	Sat, 15 Jan 2022 02:07:59 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EF5FE4111B;
	Sat, 15 Jan 2022 02:07:58 +0100 (CET)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by mails.dpdk.org (Postfix) with ESMTP id 5681640042;
 Sat, 15 Jan 2022 02:07:57 +0100 (CET)
Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.55])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JbKkY11M3z9sDx;
 Sat, 15 Jan 2022 09:06:45 +0800 (CST)
Received: from [10.67.103.128] (10.67.103.128) by
 dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.2308.21; Sat, 15 Jan 2022 09:07:55 +0800
Subject: Re: [PATCH] net/bonding: fix RSS not work for bonding in DPDK21.11
To: =?UTF-8?B?5L+e5paH5L+KX3lld3U=?= <yuwenjun_yewu@cmss.chinamobile.com>,
 tangchengchang <tangchengchang@huawei.com>, ferruh.yigit
 <ferruh.yigit@intel.com>
CC: dev <dev@dpdk.org>, stable <stable@dpdk.org>
References: <2afa61de7b9e301-0000a.Richmail.00009021307638582857@cmss.chinamobile.com>
From: "Min Hu (Connor)" <humin29@huawei.com>
Message-ID: <26d84628-cc0e-2462-3b70-674082e0c693@huawei.com>
Date: Sat, 15 Jan 2022 09:07:55 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <2afa61de7b9e301-0000a.Richmail.00009021307638582857@cmss.chinamobile.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.128]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 dggeme756-chm.china.huawei.com (10.3.19.102)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Acked-by: Min Hu (Connor) <humin29@huawei.com>

在 2022/1/12 15:29, 俞文俊_yewu 写道:
>  From 85c4ffffe32996fc262dd6f69d0ce272ae8e8350 Mon Sep 17 00:00:00 2001
> 
> From: Yu Wenjun <yuwenjun_yewu@cmss.chinamobile.com>
> 
> Date: Wed, 12 Jan 2022 15:01:10 +0800
> 
> Subject: [PATCH] net/bonding: fix RSS not work for bonding
> 
> 
> RSS don't work when upgrade to DPDK21.11.
> 
> 
> e.g.:
> 
> examples/bond/main.c:
> 
> conf:
> 
> static struct rte_eth_conf port_conf = {
> 
> .rxmode = {
> 
> .mq_mode = RTE_ETH_MQ_RX_NONE,
> 
> .split_hdr_size = 0,
> 
> },
> 
> .rx_adv_conf = {
> 
> .rss_conf = {
> 
> .rss_key = NULL,
> 
> .rss_hf = RTE_ETH_RSS_IP,
> 
> },
> 
> },
> 
> .txmode = {
> 
> .mq_mode = RTE_ETH_MQ_TX_NONE,
> 
> },
> 
> };
> 
> 
> call chain:
> 
> rte_eth_bond_create()->rte_eth_dev_configure()->rte_eth_bond_slave_add()->rte_eth_dev_start()
> 
> 
> Signed-off-by: Yu Wenjun <yuwenjun_yewu@cmss.chinamobile.com>
> 
> ---
> 
>   drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++++
> 
>   1 file changed, 5 insertions(+)
> 
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c 
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> 
> index 84f4900ee5..31bcee15cf 100644
> 
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> 
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> 
> @@ -3504,6 +3504,11 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
> 
> if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) {
> 
> struct rte_eth_rss_conf *rss_conf =
> 
> &dev->data->dev_conf.rx_adv_conf.rss_conf;
> 
> +
> 
> +if (internals->rss_key_len == 0) {
> 
> +internals->rss_key_len = sizeof(default_rss_key);
> 
> +}
> 
> +
> 
> if (rss_conf->rss_key != NULL) {
> 
> if (internals->rss_key_len > rss_conf->rss_key_len) {
> 
> RTE_BOND_LOG(ERR, "Invalid rss key length(%u)",
> 
> -- 
> 
> 2.32.0.windows.1
> 
>