From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>, dev@dpdk.org
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>,
stable@dpdk.org, Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] eal/vfio: cleanup getting group fd
Date: Wed, 26 Sep 2018 13:34:21 +0100 [thread overview]
Message-ID: <26f73861-6fac-065e-b550-219a4c365bea@intel.com> (raw)
In-Reply-To: <20180917134643.103871-2-dariusz.stojaczyk@intel.com>
On 17-Sep-18 2:46 PM, Darek Stojaczyk wrote:
> From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
>
> Factor out duplicated code.
>
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> ---
<snip>
> +
> +int
> +rte_vfio_get_group_fd(int iommu_group_num)
> +{
> + struct vfio_config *vfio_cfg;
> +
> + /* get the vfio_config it belongs to */
> + vfio_cfg = get_vfio_cfg_by_group_num(iommu_group_num);
> + vfio_cfg = vfio_cfg ? vfio_cfg : default_vfio_cfg;
I tend to prefer being explicit rather than implicit (i.e. 'vfio_cfg ==
NULL' instead of 'vfio_cfg').
Otherwise,
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-09-26 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 13:46 [dpdk-dev] [PATCH 1/2] eal/vfio: check if we already have the group fd open Darek Stojaczyk
2018-09-17 13:46 ` [dpdk-dev] [PATCH 2/2] eal/vfio: cleanup getting group fd Darek Stojaczyk
2018-09-26 12:34 ` Burakov, Anatoly [this message]
2018-09-25 7:56 ` [dpdk-dev] [PATCH 1/2] eal/vfio: check if we already have the group fd open Wang, Xiao W
2018-10-29 0:26 ` Thomas Monjalon
2018-09-26 12:35 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26f73861-6fac-065e-b550-219a4c365bea@intel.com \
--to=anatoly.burakov@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).