From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7C6CCA00C5;
	Sun,  5 Jul 2020 22:25:23 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 534CD1D8F8;
	Sun,  5 Jul 2020 22:25:23 +0200 (CEST)
Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com
 [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id A394D1D8E4
 for <dev@dpdk.org>; Sun,  5 Jul 2020 22:25:22 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailnew.nyi.internal (Postfix) with ESMTP id 25C80580420;
 Sun,  5 Jul 2020 16:25:22 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute7.internal (MEProxy); Sun, 05 Jul 2020 16:25:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 6O7flreh8k6hEmbsQms712lw1GR+5zA7A/+L8hZeuUY=; b=riD/RQ8zf7m9ALm+
 zZRFQK6hq1ronC/Ex+l1v/u3I91bHY2tVPCSog92Dtpvfo9SKk8Si7p8uQzmswcP
 j3y5DHOuaQ18yGN7Wf9sjVz+JGVHLsrUFn3AQGioz7GB3Njop3BJz5/+tzOdkvGH
 T8RbBvKk8f37Xl5nS2tD6ZEFyQeFxE8yLHeKsyY+FdjGyPpXO6C/nBaJWvmV7OI9
 BQrJe1KuzmTGolVcKxzbIj9FAHst8jAb/WZGMVMURkeJQhHZ0d/U8YxcC11fSFao
 aRfn0Bn0e+VSQYhUjrA3BP+lpHLUuorgqI4WnIWfsxw04tzay4W/UjcS8eVQ3bXW
 JNOPnQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm3; bh=6O7flreh8k6hEmbsQms712lw1GR+5zA7A/+L8hZeu
 UY=; b=mWFfdkHvvvi2m1ZYnWw7n/qEHPWgPrQmQp4GsgVdNyqlz6ArLQiuoOzE+
 7zqMnEnNI0+PsxQYRbriIFprOS/S+/6vDJD2SMEF964TIgsU6CH2rq5qeMy/ra74
 Qp/6mQQwbwt6JK3Y5AhVIbAHBcujCInMlLqnN9F0pABMtf6+LXaCovbb63+peNPB
 YOayUbW3HVQkE9ZNnHPKZkSyNOYuVXGFdRVLPl3AwGLsRB+uIjctDSHHtbPxLwNT
 ZXy24qTNq1wEyZxx23LzLGD4ecF/KsSv+W7dBemh/lpM8TuNxaZ0YgwRQT7YO+YP
 ExnTxhpNpPt2bmOwjf8d4707Yl8Gg==
X-ME-Sender: <xms:MTcCX6Xzt_dvFOuRmNz88scMgLqwVOrjUUIfIKSTdmJnB3OBTpFgvw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddugdduheduucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:MTcCX2kXS7gdxyDf1vtXle50EDD41-k9N96McjwBSmi9Vy5jQynpTg>
 <xmx:MTcCX-alLYmGWnIEwslYvK9TKox06DEpVMFjdgKPCOwdWAZ5CMh9HQ>
 <xmx:MTcCXxWzZxT5VPue4_sVXTpohrrht16LwpSZVj0I0dVF8oXG3mO7Wg>
 <xmx:MjcCX9eY42CdMxsQNKQembGv4D_HjWNn0JpForQuCOXDoPo8Stzrtg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 70DE63280059;
 Sun,  5 Jul 2020 16:25:20 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Fady Bader <fady@mellanox.com>
Cc: dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com,
 yohadt@mellanox.com, dmitry.kozliuk@gmail.com,
 harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,
 pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com,
 arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com
Date: Sun, 05 Jul 2020 22:25:19 +0200
Message-ID: <27018931.1YvKVXjScH@thomas>
In-Reply-To: <20200705134746.26240-4-fady@mellanox.com>
References: <20200705114629.2152-1-fady@mellanox.com>
 <20200705134746.26240-1-fady@mellanox.com>
 <20200705134746.26240-4-fady@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v6 3/3] mempool: mempool build on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/07/2020 15:47, Fady Bader:
> Some eal functions are used by mempool lib but not exported on Windows.

eal -> EAL

> The functions were exported.
> Added mempool to supported libraries for Windows compilation.

Please reserve the past tense for stating how it was before the patch.