From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BA31A04E7; Tue, 3 Nov 2020 21:32:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB6C26889; Tue, 3 Nov 2020 21:32:25 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 7312666DA for ; Tue, 3 Nov 2020 21:32:24 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id EA7865C01A1; Tue, 3 Nov 2020 15:32:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 15:32:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= P3AQQTIyGJ5auuDLE7DyzjXZ2rlBmzjjm/EgA6lbquA=; b=sfkstR89C3L7MqZI IuXtyzrMsXEHFciOSQXSICVXib0PBBusICmXgNoXGwG5r4mDjufv04yCqfZPeazi cEO/2/5GGt6Qxkaw+aZFDwXlRZgihns6RiNMvYAwa7CdZwn+UEnrOamTuamt/9Mq oHJBNxRc9agBT20Kdf+Ylc2Aw8vgaZ1IdxghvSWSYZlM+5BZO8kiOLJiDHY1Y7oL z10iKe1k3yG/JMWGD71fPDUjX+jA92rWXk7mb+pJcX71UP31By5U4PY6LZ62DILT wImNONar+NeJ38Wqy9VzcJXZX7BQ1qAHbfBUVwMhbH42T8LXHUj9Lo/lk8+sHKDF mC8d0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=P3AQQTIyGJ5auuDLE7DyzjXZ2rlBmzjjm/EgA6lbq uA=; b=F+4Q/IIJ6zPCFJu6zmgKovcnfMVhzJH8p9/JX4JZUV7ImUyJZGRRb55hm 3dFvAdQc6wqI9jcMY3FJ2GTd2UJvsoq0+AfkB7dvzwNj0Y8/1uCuLNmpn7IEW8B+ +zU0P9ShHew/4NL1CBswtLKSL9T9StZkO0Jul4c/PRYRUuGJor/4RJqk/8sB85x8 quJN91aYdhDhMCso/xME14kOTDRGKCsFzkXhQdgN/MVXSEKEJgn7Q2jDNH4jPV/3 SRybvOyo6iy7vZSrOWRJuq7+TsZXhf+47VPMjda+HO2FzAI3xlI951ptvXv15SRx LCBsntDxGJZtQxtXL6Heg7Hv8q77Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A5DAF32800DB; Tue, 3 Nov 2020 15:32:21 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , "Kadam, Pallavi" Date: Tue, 03 Nov 2020 21:32:20 +0100 Message-ID: <2702203.uBd2FyOzSN@thomas> In-Reply-To: <8f20cf1a-0302-cba6-58e7-6480a1ea638a@intel.com> References: <20201030183113.17829-1-dmitry.kozliuk@gmail.com> <20201030184217.19098-1-dmitry.kozliuk@gmail.com> <8f20cf1a-0302-cba6-58e7-6480a1ea638a@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: fix deadlock when setting alarm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/10/2020 20:25, Kadam, Pallavi: > On 10/30/2020 11:42 AM, Dmitry Kozlyuk wrote: > > Windows alarms are both armed and executed from the interrupt thread. > > rte_eal_alarm_set() dispatched alarm-arming code to that thread and > > waited for its completion via a spinlock. However, if called from alarm > > callback (i.e. from the interrupt thread), this caused a deadlock, > > because arming could not be run until its dispatcher exits, but it could > > only exit after it finished waiting for arming to complete. > > > > Call arming code directly when running in the interrupt thread. > > > > Fixes: f4cbdbc7fbd2 ("eal/windows: implement alarm API") > > > > Reported-by: Pallavi Kadam > > Signed-off-by: Dmitry Kozlyuk > > --- > > Tested-by: Pallavi Kadam > > Acked-by: Pallavi Kadam Applied, thanks