From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D114C42DD6; Wed, 5 Jul 2023 11:40:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FF2140ED8; Wed, 5 Jul 2023 11:40:17 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id BA0D7406BC for ; Wed, 5 Jul 2023 11:40:15 +0200 (CEST) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QwvkP6N1bzTkYl; Wed, 5 Jul 2023 17:39:09 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 5 Jul 2023 17:40:11 +0800 Message-ID: <27022343-946b-ec7e-9beb-4ad9e74e38f8@huawei.com> Date: Wed, 5 Jul 2023 17:40:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port To: Ferruh Yigit , Jie Hai CC: , , , "Mcnamara, John" , Qi Z Zhang , Yuying Zhang , Thomas Monjalon , Shiyang He , Aman Singh , "Jiale, SongX" , David Marchand References: <20230703110232.28494-1-haijie1@huawei.com> <20230704084507.12788-1-haijie1@huawei.com> <29d89a6b-49e0-8789-411f-6a89db177b91@amd.com> <74fb4fc2-6497-0ba9-e95d-71da03afd76e@amd.com> From: "lihuisong (C)" In-Reply-To: <74fb4fc2-6497-0ba9-e95d-71da03afd76e@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/7/5 16:02, Ferruh Yigit 写道: > On 7/5/2023 4:16 AM, lihuisong (C) wrote: >> 在 2023/7/4 18:59, Ferruh Yigit 写道: >>> On 7/4/2023 9:45 AM, Jie Hai wrote: >>>> Function update_queue_state updates queue state of all queues >>>> of all ports, using the queue num nb_rxq|nb_txq stored locally >>>> by testpmd. An error on the invalid queue ID occurs if we run >>>> testpmd with two ports and detach-attach one of them and start >>>> the other port first. This is because the attached port has not >>>> been configured and has no queues, which differs from nb_rxq|nb_txq. >>>> The similar error happens in multi-process senoris if secondary >>>> process attaches a port and starts it. >>>> >>>> This patch updates queue state of the specified port, which has >>>> been configured by primary process. As the secondary process >>>> cannot configure the ports, make sure that the secondary process >>>> starts the port only after the primary process has done so. >> Now look good to me. >> Acked-by: Huisong Li >>>> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling >>>> all queues") >>>> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet >>>> forwarding") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Jie Hai >>>> >>> The problem description and solution looks reasonable to me, but Intel >>> testing still reporting the issue. >>> >>> There is a chance that the issue Intel side observing is different, >>> waiting for more information from Intel test team. >>> >>> . > Hi Song, > > As far as I understand this patch works with an update from ixgbevf > driver, can you please confirm? > And can we have the ixgbevf fix soon, to not block the -rc3? > Hi Ferruh, Yes, ixgbe is not setting queue status correctly. Whether tesptmd polls the queue depends on the queue status (dev->data->rx_queue_state[queue_id]). But some drivers (not just ixgbe) do not set the status correctly. Jie is doing this. will be sent ASAP. /Huisong > .