From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E9FEA04B3; Mon, 27 Jan 2020 23:52:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A0EE1BFEE; Mon, 27 Jan 2020 23:52:24 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E3B051BFEC for ; Mon, 27 Jan 2020 23:52:22 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 15C1021EE9; Mon, 27 Jan 2020 17:52:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 27 Jan 2020 17:52:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ycCFIsacZtKT2NRSpFhrOvEH66Urx61pc8nOVlQ0ljQ=; b=dXTX3ygJNyo4 Za44KFfXdkMoNvUOmeCfR7YdkATi0ycXoQHD3ZH/yiSzrD9DME+Kynfg1BYYdcx0 Vey+ui9kWDizAtr20Om+dg4O31tyMv31dOieLF19ufjmUp98KXViqN6a0s6PtxKB kCJoFFnNw1ABfLyBbIwVZi9vxcOFHx4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ycCFIsacZtKT2NRSpFhrOvEH66Urx61pc8nOVlQ0l jQ=; b=BlSP1pjzzh1jDzgXmrseFJ0m7PMvKLTIuykb40Kl+OOh2bgPTUHRaolU5 Nq3VGt2Tn+zpt6JPbZD3/6hnoTpoMEBRbqYcvLTQx7gwIt0RXivnyGmGg+GsNFy7 AVrdTgS7JT94ojI7lT8r5D24ob7/ecHId5EGh3uTlVpboqC2BSpp1Oq1KTvTMSy0 81FEuVyqHn3FyfydwS2patqpwENnEmMIrEV4Nct0kOcPeKsyoysH06ZY/SEeZmhn dSoYYj88FkHpFP9jCvh7pa8njcMH70xcltPl5DQPoYdrJ4zvooAIKuYuZrYzY6Dx ulkL+C7fQ3wSYXiQtG4COx2RiCdyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrfeefgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D5E4328005A; Mon, 27 Jan 2020 17:52:20 -0500 (EST) From: Thomas Monjalon To: Pallavi Kadam Cc: dev@dpdk.org, Harini.Ramakrishnan@microsoft.com, keith.wiles@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinjacobk@gmail.com, ranjit.menon@intel.com, antara.ganesh.kolar@intel.com, stephen@networkplumber.org Date: Mon, 27 Jan 2020 23:52:18 +0100 Message-ID: <2703260.e9J7NaK4W3@xps> In-Reply-To: <20200113215534.10084-8-pallavi.kadam@intel.com> References: <20200109031312.6344-1-pallavi.kadam@intel.com> <20200113215534.10084-1-pallavi.kadam@intel.com> <20200113215534.10084-8-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 7/9] eal: remove syslog support for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/01/2020 22:55, Pallavi Kadam: > Added #ifndef WIN64 to exclude syslog definitions and parameters > from Windows builds. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -204,9 +206,9 @@ eal_reset_internal_config(struct internal_config *internal_cfg) > internal_cfg->hugepage_info[i].lock_descriptor = -1; > } > internal_cfg->base_virtaddr = 0; > - Please keep blank lines > +#ifndef _WIN64 Could it be #ifdef LOG_DAEMON? > internal_cfg->syslog_facility = LOG_DAEMON; > - > +#endif [..] > @@ -1391,7 +1395,7 @@ eal_parse_common_option(int opt, const char *optarg, > +#ifndef _WIN64 > case OPT_SYSLOG_NUM: > if (eal_parse_syslog(optarg, conf) < 0) { Instead of adding #ifdef, I think we could introduce eal_parse_unix_option() in a separate file, and it would call eal_parse_common_option(). So in Windows, you just skip it by calling directly eal_parse_common_option() which would be truly common.