From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id F036C1B488 for ; Sat, 24 Nov 2018 19:57:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 74C5521E49; Sat, 24 Nov 2018 13:57:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 24 Nov 2018 13:57:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=/8JD+G3PrrVX9PvYKU2S5AOUdO71IhRkrLV4A7m5b60=; b=IwIHO2357HfL caoD3YwYO9ZnfgojDNrKw6A50whU+2/g7lwsiOTHcKTIE/abbq5ddGgFG8kXWRja ntjgVtmyjLHW2ZavAxZ9tTkOPcrJITClyEUyXLjyqC+UkBqVunHPFtns66a4mcc3 KVz7vH0B3zqM06KHhT3e9Z6ZZcx3XaA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/8JD+G3PrrVX9PvYKU2S5AOUdO71IhRkrLV4A7m5b 60=; b=h3+K7u0CXrckg28m+XEz5RHnK0cf4rtgTd3vLpfMGO5D+qCzpTWNe1sPF QT0HvBBLM+emgz2ECFiVc5247tAUVBnxdC96554ea8plksL7Hku+R3QFCdmdv5nd nRW2HDbs/A/OasWcc5F4Z5ORolBZ5gwqxkg3Xd+hhZWPaqIRaZXljkxGpWNUCWNl hgyP/9zmtKh9F80RhqzeujHQM5c205cKZUBZ0rSg8IPhoPV0IvcU6LGBtqpHhmoE 6jntNcnQGkfuH6Sf3VHjq3/F7XZt8lkWX0OUsCjlYDs7SnjKE+yDKBYL1Zliw/b/ tr6X95e78iTEkIX2kECZheqYZcSQA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B8A36E407B; Sat, 24 Nov 2018 13:57:47 -0500 (EST) From: Thomas Monjalon To: "Kovacevic, Marko" , "Varghese, Vipin" Cc: dev@dpdk.org, "Richardson, Bruce" , "Mcnamara, John" , "Patel, Amol" , "Byrne, Stephen1" , honnappa.nagarahalli@arm.com Date: Sat, 24 Nov 2018 19:57:46 +0100 Message-ID: <2703864.trOpUck9ay@xps> In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F660205059B@IRSMSX104.ger.corp.intel.com> References: <20181030141345.23725-1-vipin.varghese@intel.com> <20181030141847.23861-1-vipin.varghese@intel.com> <6DC05C7C5F25994B81B3F2F214251F660205059B@IRSMSX104.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] doc: add meson build to contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Nov 2018 18:57:50 -0000 14/11/2018 15:30, Kovacevic, Marko: > > Patches has to be validated for meson builds. Updating documentation for > > meson build steps in Checking Compilation category. > > > > Signed-off-by: Vipin Varghese > > --- a/doc/guides/contributing/patches.rst > > +++ b/doc/guides/contributing/patches.rst > > @@ -468,6 +468,12 @@ The recommended configurations and options to > > test compilation prior to submitti > > export DPDK_DEP_PCAP=y > > export DPDK_DEP_SSL=y > > > > +Compliation of patches has to be tested using meson:: > > + > > + ./devtools/test-meson-builds.sh > > + > > +This will test for shared and static builds. If gcc arm cross compiler > > +is installed, cross build is tested too. > > > > Sending Patches > > --------------- > > Ran the script all runs fine > > Tested-by: Marko Kovacevic > Acked-by: Marko Kovacevic Yes we must add such explanation, but it can be improved. We should make clear that meson must be tested in addition of make. We could be more explicit about cross-compilation, saying on x86 host, both x86 and Arm can be compiled thanks to the cross compilers. More details: - s/Compliation/Compilation/ - the double blank line is removed before next header