From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5842A432FF; Sat, 11 Nov 2023 11:11:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2183400D7; Sat, 11 Nov 2023 11:11:36 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id E00804003C for ; Sat, 11 Nov 2023 11:11:34 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2306532005BC; Sat, 11 Nov 2023 05:11:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 11 Nov 2023 05:11:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699697492; x=1699783892; bh=gKv41gqzvqMcqJlKhpA781TxWVipcdEQDjC 3YSvTUZU=; b=TyimAm+9B9i6NpDxGn36H+pcMSopgGUuIxWZuU+H8aoTD5ZGHg1 yBnKPDmfuKFBKKBb2XPHNVAC02DD0hGD6+e0jw1p8mAijE9TZ/PKbRoKm43LHK2P 2uQS+peMywuIDseOZbuuOWpH6GsI0RIcq3ZeeIDBtn2JxImkR9V8siLctKu/1PBT Meioc1NjRLQvqtxwniatT/SkYoy0uL/095/RBaU6xQ8zeYXE3BFvbsxF/R4veasp iYZf/i2G+xXt1/rJ6BveCfEH7sl2fi5Brs+z1MbIzXu+K50/hs6+Bns9wICO2WoR yh5t5HvZCk61zJt5dC59ssD8yRuWLulf1cA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699697492; x=1699783892; bh=gKv41gqzvqMcqJlKhpA781TxWVipcdEQDjC 3YSvTUZU=; b=DvtxdwihWkdsZi3EEEDuqY+KADINaDcGTPcemoiaaScf+AmliKA bbcL545acvN4svygD7YfPANvHLEo++LlG9jxJKIJevRZ8nJm/PqCEcTZaBezqLqt XEhRL/SuzIZjD3pMtxuxB5wwxjQc16nrVX8w6kk+AdBEh9xkjMPUTVv8Ej1In2T3 KB7jNIHqmCl/BPSmq5JIUxuUSMkpNjKeGSETCDUgMRVOzfEHmVh6taImWfQDoa6l PW6kZUHXFBjNezUWBUfxqOqddTeQyAbwreky3ZBB6dcC7H9vLgtTx11UfDzsiezs BD9YRjnlRR9516K2XgW58DIQOtZNn8nZxWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvhedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Nov 2023 05:11:30 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff , Ferruh Yigit Cc: dev@dpdk.org, Andrew Rybchenko , Cristian Dumitrescu Subject: Re: [PATCH] ethdev: add extension keyword to statement expression macro Date: Sat, 11 Nov 2023 11:11:28 +0100 Message-ID: <2703987.mvXUDI8C0e@thomas> In-Reply-To: <7accc638-f55b-4da2-bdf8-5b55fca9e4e3@amd.com> References: <1699560818-7453-1-git-send-email-roretzla@linux.microsoft.com> <7accc638-f55b-4da2-bdf8-5b55fca9e4e3@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/11/2023 18:22, Ferruh Yigit: > On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: > > add missing __extension__ keyword to macros using gcc statement > > expression extension. > > > > Signed-off-by: Tyler Retzlaff > > > > Acked-by: Ferruh Yigit > > > It seems there are a few more usage not marked in lib folder [1], and > more including drivers. Please let's mark all at once. > Is this compiler extension causing any problem for the Windows build or > MSVC toolchain? I have the same question: is __extension__ supported in MSVC? > [1] > $ grep -r '({' lib/ | grep -v __extension__ > lib/port/rte_port_source_sink.c:({ > lib/port/rte_port_source_sink.c:({ > lib/pipeline/rte_swx_pipeline_internal.h:({ > lib/pipeline/rte_pipeline.c: ({ (p)->n_pkts_ah_drop = > lib/pipeline/rte_pipeline.c: ({ (counter) += (p)->n_pkts_ah_drop; > lib/pipeline/rte_pipeline.c: ({ (p)->pkts_drop_mask = > lib/pipeline/rte_pipeline.c:({ > lib/ethdev/rte_mtr.c:({ > lib/ethdev/rte_mtr.c:({ > lib/ethdev/rte_tm.c:({