From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 4BEF6593E for ; Thu, 16 Oct 2014 19:00:04 +0200 (CEST) Received: by mail-wi0-f172.google.com with SMTP id n3so2088787wiv.17 for ; Thu, 16 Oct 2014 10:07:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=6X7V6gSJVBT766Bf6Ub26FFhOoYsv4bmoX20xrDFf5g=; b=N0QYm9+LJReSScsjr5dVqclu0BQREDiF4IyCnKBpwJBzCDdceIqTvEANdL4Xg4Q3A4 JtyI+W6h5H8w4VKvjrSyVsqO8LKcEiaOj9YzbASqok6WZYCPyRxGWX/48oJdRDov1a8o yT1onqB+lKOWWBuCfRPubQCVcTd1OQlvn0IkbqAlEu8Qm/e22inZm/epRf2jOuSBG+1o zTEn9wJ2Bl0HUDSq3aHuKU72/QtpMwffGZiSsDuNanxZhuszmYA/zICZNHyhyrVnIqQ3 HPqIxe8St6TTsICVOHC8O6nvnODDOc0KNEmEj5Bt4eUffYYfYY4zo4D95n1YUGVzUXfN TRyA== X-Gm-Message-State: ALoCoQnEiirFEBh67cIslLCaU1cF+IdO3oN1abCFLuYMU0WyfwyDTKIfj3Oe6zVdq0iIpyZ8F9kl X-Received: by 10.180.10.231 with SMTP id l7mr22318927wib.1.1413479278535; Thu, 16 Oct 2014 10:07:58 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id t10sm10342794wja.43.2014.10.16.10.07.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Oct 2014 10:07:57 -0700 (PDT) From: Thomas Monjalon To: Jijiang Liu Date: Thu, 16 Oct 2014 19:07:41 +0200 Message-ID: <2704728.hMKqjFbCSn@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1413006935-22535-2-git-send-email-jijiang.liu@intel.com> References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com> <1413006935-22535-2-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 1/8]i40e:support VxLAN packet identification in librte_ether X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2014 17:00:04 -0000 2014-10-11 13:55, Jijiang Liu: > Add data structures and APIs in librte_ether for supporting tunneling UDP port configuration on i40e, > Currently, only VxLAN is implemented, which include > - VxLAN UDP port initialization > - Add APIs to configure VxLAN UDP port Please could you explain in the commit log how it is related to filtering? [...] > + /** > + * Add tunneling UDP port configuration of Ethernet device tunneling UDP or UDP tunneling? Please, explain what the device could do with these informations. Offloading? Filtering? > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param tunnel_udp > + * Where to store the current Tunneling UDP configuration > + * of the Ethernet device. Many words are useless here. "UDP tunneling configuration" should be sufficient. > + * @param count > + * How many configurations are going to added. It's a verbose commenting style, but why not. Typo: "to be added". > + * > + * @return > + * - (0) if successful. > + * - (-ENODEV) if port identifier is invalid. > + * - (-ENOTSUP) if hardware doesn't support tunnel type. > + */ > +int > +rte_eth_dev_udp_tunnel_add(uint8_t port_id, > + struct rte_eth_udp_tunnel *tunnel_udp, > + uint8_t count); Thanks -- Thomas