DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, kirill.rybalchenko@intel.com,
	Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments
Date: Tue, 20 Apr 2021 03:02:18 +0200	[thread overview]
Message-ID: <2705355.EUp28jVomR@thomas> (raw)
In-Reply-To: <89cedfc0-9a44-43ea-2390-7eeb65c1b4ab@intel.com>

12/04/2021 10:04, Ferruh Yigit:
> On 4/10/2021 10:11 AM, Min Hu (Connor) wrote:
> >> This patch deletes the comments which are wrong and unnecessary.
> >>
> >> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> >> ---
> >> --- a/examples/ptpclient/ptpclient.c
> >> +++ b/examples/ptpclient/ptpclient.c
> >> -    /*
> >> -     * Check that the port is on the same NUMA node as the polling thread
> >> -     * for best performance.
> >> -     */
> >>       printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
> >>               rte_lcore_id());
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> The comment seems left over from the example this example cloned from..

Applied, thanks



      parent reply	other threads:[~2021-04-20  1:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27  7:36 Min Hu (Connor)
2021-04-10  9:11 ` Min Hu (Connor)
2021-04-12  8:04   ` Ferruh Yigit
2021-04-19  7:42     ` Min Hu (Connor)
2021-04-20  1:02     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2705355.EUp28jVomR@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=humin29@huawei.com \
    --cc=kirill.rybalchenko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).