From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0495A0A0A; Fri, 22 Jan 2021 11:21:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6073140F7D; Fri, 22 Jan 2021 11:19:36 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 55BAF140F4C for ; Fri, 22 Jan 2021 11:19:28 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id C2DE2580503; Fri, 22 Jan 2021 05:19:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 22 Jan 2021 05:19:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= IBj+EzA3G49irva4J+BEt3WX2V0psMClvXvKQ6E+JuU=; b=pl8DlgHVgjpR3mpl 8yBoQsufHFsx+K6V6j7ASNY0iRRKOqwwAsy8U3P37zRCvVIA4u+BlgzrTmrozHd8 FDuA1u4gwQ3dDLVTJBZINjzFkdV4f/tSrCzxDRNX6lUkPBXYY/LCkrR25JjCejwP fCedhBGJ/+vm755JVjdzBUQVH93oZSM24cc+mLl8hFYbXjuoz/cQxqZEekB3kFlx ZRTvpmxAqXOpjKCdubMN8cmbn0xjwqT2pNQKL7n5ZylcpR9bxOPHkMUJzENvd/Nd gy0rzfeSzoEzx9TFDqkRQpPnl0WLJHT7P+T6sAS6z83fft4NfFfpTRdFRKJyZvj3 aSR/rA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=IBj+EzA3G49irva4J+BEt3WX2V0psMClvXvKQ6E+J uU=; b=mmmw3VDxZAuEu/JoiMSX4j/bM1cXwW2h12P5EG4vWmU6+pQdfUh96YOHQ +p4jKWAbVPZYtPV5Dc+LDwY4gGPbYXnOgwVOK6QpnOYDPu4BPgIXRNxm9wxb3oZ1 bjMr6BFTAQ2dhbr+ymuKxUkIdqylSVzw83g8VH7T5dDRuXNQ206L01ao0rul68ta /SSHrKcxSiwX1NuMhnWy5FHvM1Bbhy/2U3dpEnuDqY0bL0bZlQNZzZAt7QRmoOZM 7lw0pRqjo6Hhk8rRnciDxfHtgt6zv8H5wXIbSIL8wt2JiPosdc0gXWXABVH4qAci hg0n2GFMvYrommQl6bLyPZ/tH6OPA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeigdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0CBE024005B; Fri, 22 Jan 2021 05:19:23 -0500 (EST) From: Thomas Monjalon To: Jerin Jacob Cc: Honnappa Nagarahalli , Juraj =?utf-8?B?TGlua2XFoQ==?= , "bruce.richardson@intel.com" , Ruifeng Wang , Phil Yang , "vcchunga@amazon.com" , Dharmik Thakkar , "hemant.agrawal@nxp.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , "ferruh.yigit@intel.com" , "aboyer@pensando.io" , "dev@dpdk.org" , "lironh@marvell.com" , "allain.legacy@windriver.com" , nd Date: Fri, 22 Jan 2021 11:19:22 +0100 Message-ID: <2709196.oA3pVeJT1q@thomas> In-Reply-To: References: <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech> <2025364.IVKG2jy1nW@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/01/2021 10:07, Jerin Jacob: > On Fri, Jan 22, 2021 at 2:28 PM Thomas Monjalon wro= te: > > 22/01/2021 09:39, Juraj Linke=C5=A1: > > > > > > > disabled drivers, similarly how the command line option works= and > > > > > > > remove unneeded driver options ported from the old makefile > > > > > > > system, since they don't work in the current Meson build syst= em. > > > > > > > Add support for removing drivers for cross builds so that we = can > > > > > > > disable them in cross files. > > > > > > > > > > > > Why disabling them? > > > > > > If a driver is not supported it should disable itseld in its me= son file. > > > > > > > > > > > > > > > > This is helpful when building for an SoC where we don't want to b= uild > > > > > to build a driver, but the build machine actually supports the dr= iver. > > > > > I believe in this case the meson build system would find the > > > > > dependencies and designate the driver to be build, but we don't w= ant to build > > > > the driver for that SoC. > > > > > > > > > > There may be other reasons as well - Honnappa or others from the = Arm > > > > > community may shed more light on this. > > > > IMO, the assumption should be everything compiles on all the platfo= rms. Hence, > > > > the disables should be applied to the platforms where the drivers d= o not > > > > compile. > > > > If a driver does not compile, it can disable itself. > > No need for a configuration. > > > > > Would it be okay to leave the disabled as they're in this commit and = leave the updates to the plaform owners? Thomas, what do you think? > > > > I think this patch should not disable drivers but just add the infra to= do it. >=20 > IMO, If the SOC has "fixed" set of dpdk devices, probably better to > have positive logic to enable only those in config file. > I think, that will be portable and useful. > IMO, We can have infrastructure code enable only specific drivers and > config owners can later enable the required set. Yes you're right, enabling makes more sense than disabling for SoCs.