From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A9D8A0093; Tue, 19 May 2020 09:46:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53E281D423; Tue, 19 May 2020 09:46:02 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A4B2D1D37F for ; Tue, 19 May 2020 09:46:00 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 44D6F5C00AF; Tue, 19 May 2020 03:46:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 19 May 2020 03:46:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 9aB8sfrvIFIHRVUFmGJyfIV9Ceb7mA8+o79Tn3LYmyg=; b=BFQHv2De8IVw26H2 z4nt7+/tD679s4AEF9rkRHih3pGwsHTqkhmnYjAOaOAKKHmBC9buSj8M6PD5LkzI WPRHKzLvHj6kVl6bSsG+H/uJ7hUE+L/S2wJxryoR1d1wPD+w8ixLx6wvjdbNkHD8 +QvEKMxrStHspXnjFJ21fpkzP8Ih+KWHy99ochCDm4HpNE5L0a/5f5yQshmuYi/G B1rImIJyHwGD0Kko+VwZFbAt3otCupKGTq8rvx6BW9DhLhS59wetC7POIkzYOMoG 3VTeIJYgu9nrudZY1RcKR1rvwQdrlt03SxFhWTfY16AFRHIEwc71y0kyflFAWg0G yw/d9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9aB8sfrvIFIHRVUFmGJyfIV9Ceb7mA8+o79Tn3LYm yg=; b=otckdKQIt455ytKgR4DrwAjuWiTZ4rPIQxBB7QPcoBEkAEjOMDxujJmDa WgX0uIbFhG/dH06XsNznZt51951Dt35xu0kNy2+wGjb2BB1RDlvpKz6yHHxi/Fsn eruVQM72CBvudO8mxK37soo/GbD4nWJ0H1u544cXPsgJV65V77BwzCuKV7FxwFOE W4rMPHas8EEvJ04YdWTOl7xKfYmhdwYIl/T55g637lrsHU1m3rVdgJdcnqU7Udj+ RwTNThkOxNWf9B4DXaEruhDXVQNLI9DhNaTmAysvt/nQ0QQC2qu4SyFoemz8FXCx zMoOJ08WkUgyRtsLb9ElZh7sgvh9A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtiedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 09557306640A; Tue, 19 May 2020 03:45:58 -0400 (EDT) From: Thomas Monjalon To: Bernard Iremonger , John McNamara , Marko Kovacevic , Dharmik Thakkar , ferruh.yigit@intel.com Cc: Wenzhuo Lu , Jingjing Wu , dev@dpdk.org, nd@arm.com, david.marchand@redhat.com Date: Tue, 19 May 2020 09:45:57 +0200 Message-ID: <2709611.dT8XKq9c71@thomas> In-Reply-To: <20200508223829.3228-4-dharmik.thakkar@arm.com> References: <20200506215847.7628-1-dharmik.thakkar@arm.com> <20200508223829.3228-1-dharmik.thakkar@arm.com> <20200508223829.3228-4-dharmik.thakkar@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 4/5] doc: include config options in testpmd user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/05/2020 00:38, Dharmik Thakkar: > Update testpmd documentation to include RECORD configuration options, > CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and > CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS. > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Phil Yang > --- > +#. If required, enable configuration options. For example: > + > + .. code-block:: console > + > + cd to the top-level DPDK directory > + sed -i 's,\(CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES\)=n,\1=y,' config/common_base > + sed -i 's,\(CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS\)=n,\1=y,' config/common_base Changing source code is wrong. Only the generated .config file should be changed. Not even speaking about meson... Why we don't have any review on documentation patches? Patch dropped from next-net pulling.