DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: Vipin Varghese <vipin.varghese@intel.com>,
	dev@dpdk.org, deepak.k.jain@intel.com
Cc: nikhil.rao@intel.com
Subject: Re: [dpdk-dev] [PATCH] eventdev/eth_rx_adapter: update the note field
Date: Fri, 18 May 2018 11:00:55 +0530	[thread overview]
Message-ID: <270b7785-82df-13b2-09d3-1cf8d819dd85@intel.com> (raw)
In-Reply-To: <1526545170-149383-1-git-send-email-vipin.varghese@intel.com>

Hi Vipin,

Thanks for the patch, I have a suggestion below.

On 5/17/2018 1:49 PM, Vipin Varghese wrote:
> rte_event_eth_rx_adapter_create allocates eth_devices for currently
> available eth devices. For dynamically created eth devices a new instance
> for rx adapter has to be created.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
>   lib/librte_eventdev/rte_event_eth_rx_adapter.h | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> index 834eb53..0ef18ce 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> @@ -63,7 +63,10 @@
>    * rte_event_eth_rx_adapter_service_id_get() function can be used to retrieve
>    * the service function ID of the adapter in this case.
>    *
> - * Note: Interrupt driven receive queues are currently unimplemented.
> + * Note:
> + * 1) Interrupt driven receive queues are currently unimplemented.
> + * 2) rte_event_eth_rx_adapter_create() is not accounted for dynamic
> + *    eth devices.
>    */
Reword:
2) Devices created after calling rte_event_eth_rx_adapter_create() 
should be added to a new instance of the rx adapter.
>   
>   #ifdef __cplusplus
With the change above
Acked-by: Nikhil Rao <nikhil.rao@intel.com>

  reply	other threads:[~2018-05-18  5:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17  8:19 Vipin Varghese
2018-05-18  5:30 ` Rao, Nikhil [this message]
2018-05-21 10:29   ` Varghese, Vipin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=270b7785-82df-13b2-09d3-1cf8d819dd85@intel.com \
    --to=nikhil.rao@intel.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).