From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 11F6BAAC3 for ; Fri, 18 May 2018 07:31:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2018 22:30:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,413,1520924400"; d="scan'208,217";a="229569679" Received: from nikhilr-mobl.amr.corp.intel.com (HELO [10.106.138.3]) ([10.106.138.3]) by fmsmga005.fm.intel.com with ESMTP; 17 May 2018 22:30:56 -0700 To: Vipin Varghese , dev@dpdk.org, deepak.k.jain@intel.com References: <1526545170-149383-1-git-send-email-vipin.varghese@intel.com> From: "Rao, Nikhil" Cc: nikhil.rao@intel.com Message-ID: <270b7785-82df-13b2-09d3-1cf8d819dd85@intel.com> Date: Fri, 18 May 2018 11:00:55 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1526545170-149383-1-git-send-email-vipin.varghese@intel.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eventdev/eth_rx_adapter: update the note field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 05:31:01 -0000 Hi Vipin, Thanks for the patch, I have a suggestion below. On 5/17/2018 1:49 PM, Vipin Varghese wrote: > rte_event_eth_rx_adapter_create allocates eth_devices for currently > available eth devices. For dynamically created eth devices a new instance > for rx adapter has to be created. > > Signed-off-by: Vipin Varghese > --- > lib/librte_eventdev/rte_event_eth_rx_adapter.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h > index 834eb53..0ef18ce 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h > @@ -63,7 +63,10 @@ > * rte_event_eth_rx_adapter_service_id_get() function can be used to retrieve > * the service function ID of the adapter in this case. > * > - * Note: Interrupt driven receive queues are currently unimplemented. > + * Note: > + * 1) Interrupt driven receive queues are currently unimplemented. > + * 2) rte_event_eth_rx_adapter_create() is not accounted for dynamic > + * eth devices. > */ Reword: 2) Devices created after calling rte_event_eth_rx_adapter_create() should be added to a new instance of the rx adapter. > > #ifdef __cplusplus With the change above Acked-by: Nikhil Rao