From: Thomas Monjalon <thomas@monjalon.net>
To: gakhil@marvell.com, Srujana Challa <schalla@marvell.com>
Cc: roy.fan.zhang@intel.com, dev@dpdk.org, jerinj@marvell.com,
ndabilpuram@marvell.com, anoobj@marvell.com
Subject: Re: [PATCH] doc: announce change to cryptodev cb function prototype
Date: Sun, 17 Jul 2022 12:37:27 +0200 [thread overview]
Message-ID: <2710852.BEx9A2HvPv@thomas> (raw)
In-Reply-To: <20220624134524.3461406-1-schalla@marvell.com>
24/06/2022 15:45, Srujana Challa:
> Function rte_cryptodev_cb_fn prototype will be extended to
> add new parameter qp_id, to return queue pair ID, which got
> error interrupt to the application, so that application can
> reset that particular queue pair.
>
> https://mails.dpdk.org/archives/dev/2022-June/245428.html
>
> Signed-off-by: Srujana Challa <schalla@marvell.com>
> ---
> +* cryptodev: The function pointer ``rte_cryptodev_cb_fn`` will be updated to
> + have another parameter ``qp_id`` to return the queue_pair ID which got error
> + interrupt to the application so that application can reset that particular
> + queue pair.
I think it is a wrong decision.
Some events may not be related to queues.
You cannot add all events infos in the callback.
In ethdev, we are querying the event infos with additional functions,
specific to the event type.
Applied, but I will try to convince you to not do it.
prev parent reply other threads:[~2022-07-17 10:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 13:45 Srujana Challa
2022-06-24 18:09 ` Akhil Goyal
2022-07-12 11:57 ` Hemant Agrawal
2022-07-06 9:11 ` Zhang, Roy Fan
2022-07-11 14:52 ` Jerin Jacob
2022-07-12 11:55 ` Akhil Goyal
2022-07-17 10:37 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2710852.BEx9A2HvPv@thomas \
--to=thomas@monjalon.net \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=schalla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).