From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C63CA04FD; Sun, 17 Jul 2022 12:37:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35BCA40695; Sun, 17 Jul 2022 12:37:34 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 5F8DF40687 for ; Sun, 17 Jul 2022 12:37:32 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1B6895C0088; Sun, 17 Jul 2022 06:37:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 17 Jul 2022 06:37:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658054250; x= 1658140650; bh=iIYK1G548Fxvu3LeS4kVltaU1Vw7VkYFc1H/MblDYdo=; b=f e0FSJMdnQOt8GmgyAmWRK+GT3NQ/xZaAxAgLj4NReHE0n2CPvDUYEaPFCgCpqE78 1R4G/VVOis8P3sKan4usk1YYi/xLs+qPe7S6/+xJHDJQsvyEeDaKL0yzkWdDAY+u au8J2K/zoZTpkx3TLpQaXDXzNrIOs9HR4IrblGqmGe3sSguxW+4i/f1BnKz+ifOO YYU+lJFX6LkFTkYW4/TWUkg76iqUpZOnuZu4Wh6OIJFk+uPSbTg0kj9FeupFyNwS G6GC3eK8bkBKm8/ilTHpFrDjTPk9lAmF6x1+XvVw7aECjs4D5Iq/oRhFRRSvEIp+ bnmNH6QvKjhJ57a/H0fPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658054250; x= 1658140650; bh=iIYK1G548Fxvu3LeS4kVltaU1Vw7VkYFc1H/MblDYdo=; b=a fWFyPYQdhUVrSSofZ7N3WNc7h/UFIvvLAxOsBsTuMqeZCI1kAafv18TgFIczaQr7 Nv4xV4Kem2QbQSbZnKuSM4K1r3rt99NjaQ4PPh/lEEcR0VWXFmI+tDmzyMD4Ohwj IKfz8sKUucsuPSEn9AQw7B9n3zTItPy/GHRHc9gUISs9b3NER3UB91xpFPuAfalr zXk9lx1pvwuWpW7jkEDkYGRJ3VwhDrObsBXtQxkorfi5d29eqDkHCpSbtWosorTv DJxSyQ95Ub439mLp+Qn93cjX70oFLbuwhWb2msR1cz4RVnUqBFtvbJczKW55NwLC faEhaGxjfOgw6QucyrLww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekiedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 17 Jul 2022 06:37:28 -0400 (EDT) From: Thomas Monjalon To: gakhil@marvell.com, Srujana Challa Cc: roy.fan.zhang@intel.com, dev@dpdk.org, jerinj@marvell.com, ndabilpuram@marvell.com, anoobj@marvell.com Subject: Re: [PATCH] doc: announce change to cryptodev cb function prototype Date: Sun, 17 Jul 2022 12:37:27 +0200 Message-ID: <2710852.BEx9A2HvPv@thomas> In-Reply-To: <20220624134524.3461406-1-schalla@marvell.com> References: <20220624134524.3461406-1-schalla@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/06/2022 15:45, Srujana Challa: > Function rte_cryptodev_cb_fn prototype will be extended to > add new parameter qp_id, to return queue pair ID, which got > error interrupt to the application, so that application can > reset that particular queue pair. > > https://mails.dpdk.org/archives/dev/2022-June/245428.html > > Signed-off-by: Srujana Challa > --- > +* cryptodev: The function pointer ``rte_cryptodev_cb_fn`` will be updated to > + have another parameter ``qp_id`` to return the queue_pair ID which got error > + interrupt to the application so that application can reset that particular > + queue pair. I think it is a wrong decision. Some events may not be related to queues. You cannot add all events infos in the callback. In ethdev, we are querying the event infos with additional functions, specific to the event type. Applied, but I will try to convince you to not do it.