DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/1] ethdev: fix handling of close failure
@ 2021-01-22 17:58 Thomas Monjalon
  2021-01-25  9:13 ` Andrew Rybchenko
  2021-01-25 10:51 ` [dpdk-dev] " Burakov, Anatoly
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Monjalon @ 2021-01-22 17:58 UTC (permalink / raw)
  To: dev
  Cc: stable, Anatoly Burakov, Ferruh Yigit, Andrew Rybchenko,
	Liron Himi, Stephen Hemminger

If a failure happens when closing a port,
it was unnecessarily failing again in the function eth_err(),
because of a check against HW removal cause.
Indeed there is a big chance the port is released at this point.
Given the port is in the middle (or at the end) of a close process,
checking the error cause by accessing the port is a non-sense.
The error check is replaced by a simple return in the close function.

Bugzilla ID: 624
Fixes: 8a5a0aad5d3e ("ethdev: allow close function to return an error")
Cc: stable@dpdk.org

Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_ethdev/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index daf5f24f7e..89455a432e 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -1820,7 +1820,7 @@ rte_eth_dev_close(uint16_t port_id)
 	rte_ethdev_trace_close(port_id);
 	*lasterr = rte_eth_dev_release_port(dev);
 
-	return eth_err(port_id, firsterr);
+	return firsterr;
 }
 
 int
-- 
2.30.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-27 11:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-22 17:58 [dpdk-dev] [PATCH 1/1] ethdev: fix handling of close failure Thomas Monjalon
2021-01-25  9:13 ` Andrew Rybchenko
2021-01-25 12:37   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-01-25 12:39     ` Thomas Monjalon
2021-01-27 11:44   ` Ferruh Yigit
2021-01-25 10:51 ` [dpdk-dev] " Burakov, Anatoly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).