From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id BBAEA1B6FA for ; Tue, 3 Apr 2018 14:20:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 40676213DC; Tue, 3 Apr 2018 08:20:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 03 Apr 2018 08:20:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=yxLeh3QlmauglfVn5kXVF/9ASt o3t8pp5PoVxn70nvE=; b=YUvK7NeU52Q30+nXaLiYB5JQkLVnHVvV3ci6W51mUR H1Gdy+6kdjBL5YqqWI5Kz81GVpcgq/cPh2/asOxqowDlBozyzz7Yy/DQtghDnuVo mv9sS4+kciIdBRiWzKnr/YZCJnaxW13L/a3JsArj1FtQENaQ+jQCiW8T3bnLIJ1V o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=yxLeh3 QlmauglfVn5kXVF/9ASto3t8pp5PoVxn70nvE=; b=kzl+XOHeUrAhtJzTx9NrJO FMHYH+qxtwBQcYerbZrQ4a5bEO8ftX2kmkd37QSaFWbad7OJTYq6arTr+qRsXsP7 pDhly4ylG224GKQ0hfl5RT+sbXpClSRB6UvRTzE8cQnekABuW3n+gHtHmKzMKINn uzu0mV4ZjtyWkSD/O7ZPV+3HCcOjRfTd3xrascyrZ9cqFADxrnbB77XoOLxlkDGX oMGwtFAESxGcM/+EtULk/MW0Nw0rtZ8RXP0N8a9Qzhs2J6LAydJBcQt/jYQUr2ni fzTHpifrd4RvVMr5C0dlJTJLHQ7dfC9bCzRlAJ48EncBzBXOhGhhpRdMKa1Nl9gQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7D80DE5096; Tue, 3 Apr 2018 08:20:55 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Ferruh Yigit , John McNamara , Marko Kovacevic , dev@dpdk.org Date: Tue, 03 Apr 2018 14:20:30 +0200 Message-ID: <2713963.Nlhf7d0HAF@xps> In-Reply-To: <20180403105755.GB3544@bricha3-MOBL.ger.corp.intel.com> References: <20180403092859.71589-1-ferruh.yigit@intel.com> <8464158.iTavIsMWKz@xps> <20180403105755.GB3544@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 12:20:57 -0000 03/04/2018 12:57, Bruce Richardson: > On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote: > > 03/04/2018 11:28, Ferruh Yigit: > > > Library folder name and output library name are same except a few flaws > > > including librte_ether. > > > > > > This library is network device abstraction layer, the name "ethdev" fits > > > better than "ether", and library & header files already named as ethdev. > > > > > > Also there is a rte_ether.h in the net library which can cause confusion. > > > > > > Signed-off-by: Ferruh Yigit > > > --- > > > Not sure if the we are ready for this change J > > > > > > This is one the issues that the hassle of the change doesn't worth the > > > benefit and you may prefer to live with the flaw. > > > > > > Also a concern is this breaks the git history. > > > > Yes it breaks the git history. > > I am a big user of gitk. Do you know how to follow the history after rename > > with gitk? > > > > I think it is a good change but I would like to be sure it will not > > bother us every day. > > > For those of use with even slight OCD, having it the way it is bothers us > every day! :-) > I view this as something that we really should do some day - it's just > broken the way the way it is right now - and so the sooner we take the hit > and fix it, the better. Yes > If you do need to find the history of the file, would git blame work well > enough for you? No, blame is not enough, but it does not matter. When should we do this rename? 18.05-rc1?