From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Simon Kågström" <simon.kagstrom@netinsight.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix warning spew when EXTRA_CFLAGS specifies warning flags
Date: Mon, 07 Dec 2015 22:41:04 +0100 [thread overview]
Message-ID: <2719742.WUZHu1RK4D@xps13> (raw)
In-Reply-To: <56658E6D.6060901@netinsight.net>
2015-12-07 14:49, Simon Kågström:
> On 2015-12-07 13:56, Panu Matilainen wrote:
> > Starting with commit 9aa2053c6e81493b23346ff4e387903560de5c81
> > EXTRA_CFLAGS is sometimes being passed to the compiler without
> > WERROR_FLAGS which can cause spurious warnings by the dozen,
> > for example with when compiling with EXTRA_CFLAGS="-Wformat-security":
> >
> > cc1: warning: -Wformat-security ignored without -Wformat [-Wformat-security]
> >
> > Passing WERROR_FLAGS to AUTO_CPU helper makes the warning flag usage
> > consistent throughout the codebase, silencing the warnings.
>
> Acked-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Applied, thanks
prev parent reply other threads:[~2015-12-07 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 12:56 Panu Matilainen
2015-12-07 13:49 ` Simon Kågström
2015-12-07 21:41 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2719742.WUZHu1RK4D@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).