DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>, Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Doherty, Declan" <declan.doherty@intel.com>,
	jerin.jacob@caviumnetworks.com,
	Bruce Richardson <bruce.richardson@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 09/11] eal: replace rte_panic instances in ethdev
Date: Fri, 20 Apr 2018 15:56:56 +0200	[thread overview]
Message-ID: <2727458.a5P0WfqTky@xps> (raw)
In-Reply-To: <CAKy9EB1p9tHdCON3JHkShBaduN=Y+_wuZdh2AVvaOgdREpRc4Q@mail.gmail.com>

20/04/2018 15:23, Arnon Warshavsky:
> >
> > Lots of "!= 0"'s - you might gather by now that I don't like them :-)
> >
> 
> No way. Would have never guessed that :)
> Sure. When in Rome..

It is a matter of taste. I like the explicit "!= 0".
At least, explicit NULL comparisons are recommended in the coding style:
	http://dpdk.org/doc/guides/contributing/coding_style.html#null-pointers
For boolean return, it is OK to be implicit.
But for error codes, I think it is better to be explicit.
Again, matter of taste.

By the way, looking at "git grep 'if (rte_'" suggests it is common.

  reply	other threads:[~2018-04-20 13:56 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  6:00 [dpdk-dev] [PATCH v4 00/11] eal: replace calls to rte_panic and refrain from new instances Arnon Warshavsky
2018-04-19  6:00 ` [dpdk-dev] [PATCH v4 01/11] crypto: replace rte_panic instances in crypto driver Arnon Warshavsky
2018-04-19 10:53   ` Trahe, Fiona
2018-04-19 13:49     ` Arnon Warshavsky
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 02/11] bond: replace rte_panic instances in bonding driver Arnon Warshavsky
2018-04-19 17:25   ` Kevin Traynor
2018-04-20 13:13     ` Arnon Warshavsky
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 03/11] e1000: replace rte_panic instances in e1000 driver Arnon Warshavsky
2018-04-19 17:25   ` Kevin Traynor
2018-04-20 13:14     ` Arnon Warshavsky
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 04/11] ixgbe: replace rte_panic instances in ixgbe driver Arnon Warshavsky
2018-04-19 17:26   ` Kevin Traynor
2018-04-20 13:16     ` Arnon Warshavsky
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 05/11] eal: replace rte_panic instances in eventdev Arnon Warshavsky
2018-04-19 17:26   ` Kevin Traynor
2018-04-20 13:17     ` Arnon Warshavsky
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 06/11] kni: replace rte_panic instances in kni Arnon Warshavsky
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info Arnon Warshavsky
2018-04-19 14:03   ` Burakov, Anatoly
2018-04-19 14:09     ` Arnon Warshavsky
2018-04-19 14:45       ` Burakov, Anatoly
2018-04-19 14:50         ` Burakov, Anatoly
2018-04-20 13:11           ` Arnon Warshavsky
2018-04-19 14:36   ` Kevin Traynor
2018-04-20 13:12     ` Arnon Warshavsky
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 08/11] eal: replace rte_panic instances in interrupts thread Arnon Warshavsky
2018-04-19 17:27   ` Kevin Traynor
2018-04-20 13:18     ` Arnon Warshavsky
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 09/11] eal: replace rte_panic instances in ethdev Arnon Warshavsky
2018-04-19 17:27   ` Kevin Traynor
2018-04-20 13:23     ` Arnon Warshavsky
2018-04-20 13:56       ` Thomas Monjalon [this message]
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 10/11] eal: replace rte_panic instances in init sequence Arnon Warshavsky
2018-04-19 14:39   ` Burakov, Anatoly
2018-04-19 14:48     ` Arnon Warshavsky
2018-04-19 14:57       ` Burakov, Anatoly
2018-04-19 17:31         ` Kevin Traynor
2018-04-20 13:32           ` Arnon Warshavsky
2018-04-20 13:31         ` Arnon Warshavsky
2018-04-19 17:48   ` Aaron Conole
2018-04-20 13:55     ` Arnon Warshavsky
2018-04-20 14:53       ` Aaron Conole
2018-04-23  8:07         ` Arnon Warshavsky
2018-04-19  6:01 ` [dpdk-dev] [PATCH v4 11/11] devtools: prevent new instances of rte_panic and rte_exit Arnon Warshavsky
2018-04-19 17:52   ` Aaron Conole
2018-04-20 14:01     ` Arnon Warshavsky
2018-04-20 15:41       ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2727458.a5P0WfqTky@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=arnon@qwilt.com \
    --cc=bruce.richardson@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=ktraynor@redhat.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).