From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1F87F7EE4
 for <dev@dpdk.org>; Fri, 20 Apr 2018 15:56:59 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id AB35321EE7;
 Fri, 20 Apr 2018 09:56:58 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Fri, 20 Apr 2018 09:56:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=0qYD5SPWHfiWQ3e0u/X6Sc8wG7
 2YRNjuCP09OUlugvY=; b=W8xZBVDE7n+SKvJSqr4EQwHhtIKMo/JD+9WQlaIYQw
 kHW3biBcQT7uBbsUUOoyfg998kCTSz96/aHUdDIOS/hLbsaKkwqrMByRz/EXxypS
 mOwkO3YGGeHtgoayHL3k4zgbwxhN3lpojkSdTI2Zyy//WFjDu6+dU3oBH2RpJU0i
 g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=0qYD5S
 PWHfiWQ3e0u/X6Sc8wG72YRNjuCP09OUlugvY=; b=RYIoDHejxz/8jdROBLKgjQ
 /uNLM2635NTozmT7n3tvNG8LgDn+LLogZ8qi+eEPh2WXALXzt4JeaFys+U+QnPnW
 rJjQ6mTMXfH1mgD0ur3/vOwSYMFLNmAXlr7q6vS9Srb68ye4qopHmQBPXU609K0S
 vpRisS+BIr/XN9enqwPhfz2Zss3EkHm49/eQSPo7dpFhSbiwy3osQKMXISv58gPA
 sAfM1aqS8AGgbdT96biJHR2QsN7XTvJtFLXah3mO2wF8Hws4yt0ueNaPu9KTa/KX
 pZm1dSs7ZQDRIBFwjvUc4ZWtEXxmiyztX9EQfjPcBRzlBBo6AxlD2AJ+n6v2cMvg
 ==
X-ME-Sender: <xms:qvHZWtxdGPOFrex7iukAVIyYaNsuuc6bnOrYaX-e5iwrysB5N750lg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 84CCBE47F2;
 Fri, 20 Apr 2018 09:56:57 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>, Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>,
 jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>
Date: Fri, 20 Apr 2018 15:56:56 +0200
Message-ID: <2727458.a5P0WfqTky@xps>
In-Reply-To: <CAKy9EB1p9tHdCON3JHkShBaduN=Y+_wuZdh2AVvaOgdREpRc4Q@mail.gmail.com>
References: <1524117669-25729-1-git-send-email-arnon@qwilt.com>
 <f307c97a-58f2-9919-9e1b-5afde681444d@redhat.com>
 <CAKy9EB1p9tHdCON3JHkShBaduN=Y+_wuZdh2AVvaOgdREpRc4Q@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 09/11] eal: replace rte_panic instances in
	ethdev
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2018 13:56:59 -0000

20/04/2018 15:23, Arnon Warshavsky:
> >
> > Lots of "!= 0"'s - you might gather by now that I don't like them :-)
> >
> 
> No way. Would have never guessed that :)
> Sure. When in Rome..

It is a matter of taste. I like the explicit "!= 0".
At least, explicit NULL comparisons are recommended in the coding style:
	http://dpdk.org/doc/guides/contributing/coding_style.html#null-pointers
For boolean return, it is OK to be implicit.
But for error codes, I think it is better to be explicit.
Again, matter of taste.

By the way, looking at "git grep 'if (rte_'" suggests it is common.