From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Zhe Tao <zhe.tao@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: Fix the endian issue for the i40e read&write registers functions
Date: Tue, 14 Jul 2015 22:03:53 +0200 [thread overview]
Message-ID: <2728205.CWfvQXyGGP@xps13> (raw)
In-Reply-To: <1436870216-12926-1-git-send-email-zhe.tao@intel.com>
2015-07-14 18:36, Zhe Tao:
> Linux kernel uses the writel and readl related functions to perform the PCI memory access via ioremap region,
> those functions will handle the big little endian properly by doing the conversion between little and big endian if necessary,
> so Add this conversion in the read&write registers functions for i40e.
You compare with the Linux implementation but you forget to describe
the problem which would be a better justification.
next prev parent reply other threads:[~2015-07-14 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 10:36 Zhe Tao
2015-07-14 20:03 ` Thomas Monjalon [this message]
2015-07-15 1:01 ` Wu, Jingjing
2015-07-17 3:46 ` [dpdk-dev] [PATCH v2] " Zhe Tao
2015-07-17 7:25 ` [dpdk-dev] [PATCH v3] i40e: " Zhe Tao
2015-07-17 8:09 ` Chao Zhu
2015-07-19 23:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2728205.CWfvQXyGGP@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=zhe.tao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).