From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id AD822E72
 for <dev@dpdk.org>; Tue, 14 Jul 2015 22:05:05 +0200 (CEST)
Received: by wgxm20 with SMTP id m20so17148495wgx.3
 for <dev@dpdk.org>; Tue, 14 Jul 2015 13:05:05 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=bUj3kUZwncTl5kMC0P0BG9YSIZrGRFTP/6j5TI64W0c=;
 b=XlmL79a71uj4HaTtg4PTNzioa3O5AHh/LOupPDyLD5oGQFuXXKvALlKrAj89BkApIk
 9UjyWvw7R6BN/zI/rkGKqKadJ7zBPov54kOlTsl2ta1fOTbS58069oSs4pSQeD9Tmxts
 ykmywnPNYBUkYNMIN2XzEfeHmbGoxrO1telsGun0EOL3KDqL+ijKeKjQGbARa48tAN0F
 eaksuUcB03QOXvfB4smyxct4tTxXjtbtWh+38Ic7YQ2bCOUVyq1pV9mohhl13V9xnxON
 X8y6VyRb4SYG+k7T3wUQQ8WDddnwobD692U5UefOqqvFHAdJ1jqx3SU2hMKR1/fiRIT6
 f1sA==
X-Gm-Message-State: ALoCoQlnYYQFx29RCUvQSfKsTPkrgfnhFtKlLt1yMTgMNBJR1iSLlf6G9ZKaBebjO02Spje+OUMF
X-Received: by 10.194.60.131 with SMTP id h3mr653348wjr.156.1436904305514;
 Tue, 14 Jul 2015 13:05:05 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id uc16sm22647219wib.8.2015.07.14.13.05.04
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 14 Jul 2015 13:05:04 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Zhe Tao <zhe.tao@intel.com>
Date: Tue, 14 Jul 2015 22:03:53 +0200
Message-ID: <2728205.CWfvQXyGGP@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1436870216-12926-1-git-send-email-zhe.tao@intel.com>
References: <1436870216-12926-1-git-send-email-zhe.tao@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: Fix the endian issue for the i40e
	read&write registers functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2015 20:05:05 -0000

2015-07-14 18:36, Zhe Tao:
> Linux kernel uses the writel and readl related functions to perform the PCI memory access via ioremap region,
> those functions will handle the big little endian properly by doing the conversion between little and big endian if necessary,
> so Add this conversion in the read&write registers functions for i40e.

You compare with the Linux implementation but you forget to describe
the problem which would be a better justification.