From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F308EA0A02; Thu, 25 Mar 2021 11:21:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D92EE4067B; Thu, 25 Mar 2021 11:21:01 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 59ED540147 for ; Thu, 25 Mar 2021 11:21:01 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id AE6195809EC; Thu, 25 Mar 2021 06:21:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 25 Mar 2021 06:21:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= EQ/9dXR4gsNBw5jTVvYLOdJN7BoiV8e/UH1gH/ArJ2E=; b=qDLopGT0M1/NAwoB 3ZnX/UeCmnlPBEPkZmBtrGmwr34OfBI9hNnF/ORQwBwlTgfH2r6vvmnj+y/9E+5n a3vELGcXxWwGCQTK/PuEL39eXNqj7mHGN8CNJUDmcVVygOX7NLoqnW5JpqWj6uko 1/3eKVEnLAyhK85fLbJopUXI1qHZmi/QZ5ZOgdJeqJxUxI9o3r70qKwHWDidWPRb eUzVaTbt5Dr3HT0Awvw+Ooi7FDoVZTrfnyU5lESBQDLwr0+YF2oxTTvRrnmJM1U6 eDu7Wyl+M2jS2HdycCKExfOBjpiAChDPNGxJpkNWOcrEX57RmmFMdHRL54W7ZKDy TfiofA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=EQ/9dXR4gsNBw5jTVvYLOdJN7BoiV8e/UH1gH/ArJ 2E=; b=iIMIo/ILgBiJxN50mphotdTL3uoXk11O0FofGOsKK9HCfEXKCS7wPJ2mv m/daghdc3sm0V5/Hrsk8ot/lShgtnl08//1JwimHSIdDrvKp4ZW0xrSbcjolAhsj 7JGq0ZT9HFAknc8MPtWZQMeYCUx9XnfAoN1NiSaG2iI7NGj7BUyIUnGXI6gKcE09 7ZOrzJhuUi/JREWAP/5KW4CqYeb/eBrs4bGttsSwS+hfCPSludAgF275YimzUVoW z37X8DdM8mnL5rF8vl9cmMQIhfl8kXv9RJQofvs9EA/PCdifQwnmP5+JsFaAGV7O p14zRkS4SU6WrwI0Vjdyf9VJnVHDA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehtddgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7EF0E240057; Thu, 25 Mar 2021 06:20:58 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Andrew Rybchenko , dev@dpdk.org, Rosen Xu , Hemant Agrawal , Sachin Saxena , Jingjing Wu , Beilei Xing , Qiming Yang , Qi Zhang , Jeff Guo , Haiyue Wang Date: Thu, 25 Mar 2021 11:20:56 +0100 Message-ID: <272955377.2llAV7lm0X@thomas> In-Reply-To: <27e1324b-886a-7e26-3215-08a10daf679e@intel.com> References: <20210311221742.3750589-1-thomas@monjalon.net> <325e1d27-3729-0768-fc0d-ef89c1db9cf5@oktetlabs.ru> <27e1324b-886a-7e26-3215-08a10daf679e@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/03/2021 11:00, Ferruh Yigit: > On 3/25/2021 5:53 AM, Andrew Rybchenko wrote: > > On 3/24/21 11:00 PM, Thomas Monjalon wrote: > >> 24/03/2021 19:08, Ferruh Yigit: > >>> On 3/21/2021 9:00 AM, Thomas Monjalon wrote: > >>>> The header file rte_eth_ctrl.h should not be needed because > >>>> this legacy filtering API is completely replaced with the rte_flow API. > >>>> However some definitions from this file are still used by some drivers, > >>>> but such usage is already covered by an implicit include via rte_ethdev.h. > >>>> > >>>> Signed-off-by: Thomas Monjalon > >>>> Acked-by: Rosen Xu > >>>> Acked-by: Hemant Agrawal > >>>> --- > >>>> drivers/net/dpaa2/dpaa2_ptp.c | 1 - > >>>> drivers/net/iavf/iavf_hash.c | 1 - > >>>> drivers/net/ice/ice_acl_filter.c | 1 - > >>>> drivers/net/ice/ice_hash.c | 1 - > >>>> drivers/net/ice/ice_switch_filter.c | 1 - > >>>> drivers/net/igc/igc_filter.h | 1 - > >>>> drivers/net/ipn3ke/ipn3ke_flow.c | 1 - > >>> > >>> Although this will work, if the above drives are using the defines from the > >>> header file, isn't it better to include it explicitly? > >>> > >>> What is the benefit of including the header implicitly? > >> > >> The benefit is to progressively remove rte_eth_ctrl.h. > >> I want it to disappear. > >> > > > > +1 > > > > This is just hiding its usage, the patch is not making it less used as a step > forward to remove it. Yes you're right. The only step forward is esthetic: hiding something which should be removed. And maybe some of these files don't need the include at all. > But anyway I guess it doesn't worth spending more time to discuss it ... Feel free to reject if you feel it is not a good step.