Re: [PATCH] Fix RISC-V builds

[Heinrich Schuchardt <heinrich.schuchardt@canonical.com>]

On 6/8/22 09:23, David Marchand wrote:
> Hello,
> 
> On Mon, May 30, 2022 at 4:11 PM Heinrich Schuchardt
> <heinrich.schuchardt@canonical.com> wrote:
>>
>> Building on RISC-V results in an error
>>
>>      cc: error: ‘-march=native’: ISA string must begin with rv32 or rv64
>>
>> As GCC does not support -march=native on RISC-V avoid this argument.
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> 
> I am finalizing the RISC-V merge for -rc1, this fix can be merged
> later as we only have cross compilation in GHA with the initial
> series.

Keith Wiles <keith.wiles@intel.com> already merged this patch into 
PktGen-DPDK.

@Keith
Maybe CONTRIBUTING.txt in that package should suggest a title prefix for 
PktGen patches to avoid future confusion.

Best regards

Heinrich

> 
> 
>> ---
>>   meson.build | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meson.build b/meson.build
>> index 507c146..bbf4650 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -17,7 +17,10 @@ pktgen_conf = configuration_data()
>>   # set up some global vars for compiler, platform, configuration, etc.
>>   cc = meson.get_compiler('c')
>>
>> -add_project_arguments('-march=native', language: 'c')
>> +target = target_machine.cpu_family()
>> +if (target != 'riscv64')
>> +    add_project_arguments('-march=native', language: 'c')
>> +endif
> 
> Would the below snippet work?
> 
> cc.has_argument('-march=native'')
>      add_project_arguments('-march=native', language: 'c')
> endif
> 
>>
>>   if get_option('enable-avx') and cc.has_argument('-mavx')
>>       add_project_arguments('-mavx', language: 'c')
>> --
>> 2.36.1
>>
> 
>