Re: [dpdk-dev] [PATCH v2 2/2] eal: add help option

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-02-03 07:33, David Marchand:
> On Mon, Feb 2, 2015 at 6:44 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> [snip]
> > @@ -340,6 +342,9 @@ eal_parse_args(int argc, char **argv)
> >                         continue;
> >
> >                 switch (opt) {
> > +               case 'h':
> > +                       eal_usage(prgname);
> > +                       exit(EXIT_SUCCESS);
> >                 default:
> >                         if (opt < OPT_LONG_MIN_NUM && isprint(opt)) {
> >                                 RTE_LOG(ERR, EAL, "Option %c is not supported "
> [snip]
> > @@ -534,6 +536,10 @@ eal_parse_args(int argc, char **argv)
> >                         continue;
> >
> >                 switch (opt) {
> > +               case 'h':
> > +                       eal_usage(prgname);
> > +                       exit(EXIT_SUCCESS);
> > +
> >                 /* force loading of external driver */
> >                 case 'd':
> >                         solib = malloc(sizeof(*solib));
> 
> Why not move those two in common parser ?

Because it's calling eal_usage() which is not callable from common parser.
eal_usage() print usage for common and environment-specific options.

-- 
Thomas