From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AA9741B13C; Mon, 14 Jan 2019 20:06:07 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5034E22635; Mon, 14 Jan 2019 14:06:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 14:06:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SsrMMLXzXViq6s6j+lFjqYMeumjhwQYJfiPTsYOR+Go=; b=g9tQxRoMaOzv 1X6XlbKY8KTcFNISWWFMbBTZFjQsDg0YPkvglFKr9Ou6bsIIPQZuP0TDc1xtH5O5 pZuQTqaZInZ+HUSXdenu1hyWLVo73jfXvVUxszAN6fL0ZOtFe2Czz910D95SMZtm awpC8OlUpJaYvudPfoWmrDeqbw9CjQY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=SsrMMLXzXViq6s6j+lFjqYMeumjhwQYJfiPTsYOR+ Go=; b=w/gm+vf15esquGRiapO5U/QN3J3bgVjqRVAkMl40rdzBUl6SpLsjQcyLQ 34taiC6BQ63Arw7y3EXYHX9YO29ZsxM7CfSbmmsLvuyF8+7bUxZ+iGXMiZaTZ1gK 6J/vNyZ+Pyr22ZpIEAWe9DqVc1WJe7tKE/ZkIKgFBVXc9QpMDweAOdBDfYS/pfFY 866/gs3gcWjJvMX4n3axc263JZUzMj0mrDeDEOcIDdHA7WOADXxZk3dEJgVMsBvG YxJGHDnseE3PqDrXsIZpT9QpFDBiwC+xOE6ZWA9dB2UU4wbNYuSlaxTr6bIGpW1G zFCsLk5xdFXjem+gulCUCqugietZA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedugdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8B754100BA; Mon, 14 Jan 2019 14:06:05 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: Ilya Maximets , stable@dpdk.org, Pavan Nikhilesh , honnappa.nagarahalli@arm.com Date: Mon, 14 Jan 2019 20:06:04 +0100 Message-ID: <2738048.OSRjOPMpyn@xps> In-Reply-To: <3867865.yVi6bGp0KD@xps> References: <2566607.iMXo4xvV1S@xps> <3867865.yVi6bGp0KD@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix build of external apps with clang on armv8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 19:06:07 -0000 14/01/2019 19:49, Thomas Monjalon: > 14/01/2019 17:27, Thomas Monjalon: > > 14/01/2019 17:14, Ilya Maximets: > > > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > > > But 'rte_atomic.h' is a generic header that included to the > > > external apps like OVS while building with DPDK. As a result, > > > clang build of OVS fails on ARMv8 if DPDK built using gcc: > > > > > > include/generic/rte_atomic.h:215:9: error: > > > implicit declaration of function '__atomic_exchange_2' > > > is invalid in C99 > > > include/generic/rte_atomic.h:494:9: error: > > > implicit declaration of function '__atomic_exchange_4' > > > is invalid in C99 > > > include/generic/rte_atomic.h:772:9: error: > > > implicit declaration of function '__atomic_exchange_8' > > > is invalid in C99 > > > > > > We need to check for current compiler, not the compiler used for > > > DPDK build. > > > > Right, API cannot rely on internal build system configuration. > > > > > Fixes: 7bdccb93078e ("eal: fix ARM build with clang") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Ilya Maximets > > > > Acked-by: Thomas Monjalon > > Applied (if armv8 typo), thanks correction: with armv8 typo fixed