From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8155A2BAE for ; Thu, 25 Oct 2018 10:58:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1F241220F6; Thu, 25 Oct 2018 04:58:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 04:58:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=L5RRSA3vFFDwrLLOg2KOWpBTWkuiGaXICwMf2CVQfdU=; b=KsnOcpFxG2Vz w4M64QFCqiIjAWukpt0qGel6kqOd2VfO1Iazy2AsmweU/FMz2H5doJ+tQOKPfGeJ 0nbl3OMIoP0sTeUS3442lishlL+MOrv8nd6cGcWNlwjhXwhdI9T83Fe/YyO+szkw P4Nxe8E9zZWRNrtOZvvRHWDSp+uHuXw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=L5RRSA3vFFDwrLLOg2KOWpBTWkuiGaXICwMf2CVQf dU=; b=wq68+UY0N34MStt0hFBTEYSSL/BSF9ml9Z8Uo6QtWXH87zcEORtSsF7aq IxxzIQQ/y6f2DT9p0jMrodv0m5N7HuJ1y9BiTBWEEm0gmAGSclDk/7QV1apbvHKV 7firZ8F8K2qj5PJ46W8lxOuf7QjlycmzdTRgSnfzfgEb0tebEdmNkZWmbeo8jZeR Lq0Az33x5ENpbmw2iFGjkFN7ci8YPClFmmwQrvs3CPpXSeapZ2/psyGCgFrGcZ8L p0VmwNSRg8iEVwBybENYNIJKrr/O8YorY5JJjLGAKB+h0A5cWWF+uKzic/YJz2Mm y8mC0FVTCIPbJvYkv4hzrXepcKKJg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 89C8C102E9; Thu, 25 Oct 2018 04:58:45 -0400 (EDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: "Wu, Jingjing" , "Lu, Wenzhuo" , "dev@dpdk.org" , "ophirmu@mellanox.com" , "wisamm@mellanox.com" , "Yigit, Ferruh" , "arybchenko@solarflare.com" Date: Thu, 25 Oct 2018 10:58:48 +0200 Message-ID: <2739182.JckHbNtxNe@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D172FD@IRSMSX107.ger.corp.intel.com> References: <20181024134111.26771-1-thomas@monjalon.net> <4409048.vUvRZhrQBt@xps> <8CEF83825BEC744B83065625E567D7C260D172FD@IRSMSX107.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 08:58:47 -0000 25/10/2018 10:54, Iremonger, Bernard: > Hi Thomas, > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 24/10/2018 17:55, Iremonger, Bernard: > > > Hi Thomas, > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > +/* Pretty printing of ethdev events */ static const char * const > > > > +eth_event_desc[] = { > > > > + [RTE_ETH_EVENT_UNKNOWN] = "unknown", > > > > + [RTE_ETH_EVENT_INTR_LSC] = "LSC", > > > > > > How about replacing "LSC" with "interrupt link status change" > > > > When it is printed, "event" is appended. > > So I think "interrupt" is a bit too much. > > OK for "link state change"? > > Yes, > > > > > + [RTE_ETH_EVENT_QUEUE_STATE] = "queue state", > > > > + [RTE_ETH_EVENT_INTR_RESET] = "interrupt reset", > > Should "interrupt" be dropped from "interrupt reset" too for consistency? Yes, you're right. > > > > + [RTE_ETH_EVENT_VF_MBOX] = "VF mbox", > > > > + [RTE_ETH_EVENT_IPSEC] = "IPsec", > > > > + [RTE_ETH_EVENT_MACSEC] = "MACsec", > > > > + [RTE_ETH_EVENT_INTR_RMV] = "device removal", > > > > > > How about replacing "device removal" with "interrupt device removal" > > > > For same reason, I think "device removal" is enough. > > It will be printed as "device removal event". I will send a v2 today. Thanks for the review.