From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49519A04DC; Mon, 26 Oct 2020 14:55:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADBA52B9D; Mon, 26 Oct 2020 14:55:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 4073A1E2B for ; Mon, 26 Oct 2020 14:55:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603720543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sPTAPTWNTwjXrO3YPddDry813cI0zHq5HgWMjVgNuCY=; b=DpkxjXc6JJZNr51SHt4cNSlgtmNT4SWDO4wRRQWZyDnxcZDRgW2OTRepB6+DphZeAcDYfH 9cgBJlw7xzo8GzYtwotS8NYIn7rhpJC2FFxyEHQiu/vCJYorQL8vjNV3O5+Kf9WgTjb00b haF10lvM7gK8RLplOtmkWJW37Yln6EM= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-voii-sTrMPiJlRnoCTOApg-1; Mon, 26 Oct 2020 09:55:42 -0400 X-MC-Unique: voii-sTrMPiJlRnoCTOApg-1 Received: by mail-oo1-f70.google.com with SMTP id e142so5714448oob.2 for ; Mon, 26 Oct 2020 06:55:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=sPTAPTWNTwjXrO3YPddDry813cI0zHq5HgWMjVgNuCY=; b=GnjcmzWT6BrLBMkuP7kchEmsJonfDD4sT7F4pXqwd2MuL0iekbkHMaOuGnucUB1gr1 gGkrLRW2Lw68JDh63B6Snvro40Dn+mEk5qkqYlog29Zte6Z2SSPK6hbBRJE3uS/al9Hm xMpGFNVciTZpgkR7PNoUJLRGUgGk7TQ0hX6EFS362u1Tt7n/SSIYEu2nulJ8asZb6HN/ DRgrbltcb+/DgPRZeDCTM7o0ACyVM3gROBRwZOIHAN7GWVBrYOeg1+zmvhMqdgjmD+28 p1cWWnYDJ+EY4UPZDfoduzIkKgLX5OzvGTTZElxJ+kF/+hVFHVElLX9D2y+rlU2rUzFo 5xEQ== X-Gm-Message-State: AOAM530Z4sEDGokDaRStHf8yHdpDJ9JXD40DqeDSqTM4eVuMZwNnoVM7 tDw0VuqNQJRgDaNSeQlR7JMCR3n13PC/UJSyaxMjo/GzkZjW/cP5XNYKUNf1jiwkWL/pqIo3/Dk Bg/8= X-Received: by 2002:a05:6808:185:: with SMTP id w5mr12835236oic.39.1603720541402; Mon, 26 Oct 2020 06:55:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWvHQX5X12O/2Z3kzIx53ScC1hrLc33OpXX5fGirRR+6Za2Lh2U1aJ94JxqOZ7m7AjFFbkpQ== X-Received: by 2002:a05:6808:185:: with SMTP id w5mr12835217oic.39.1603720541118; Mon, 26 Oct 2020 06:55:41 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id d27sm3611681otc.6.2020.10.26.06.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 06:55:40 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, akhil.goyal@nxp.com Cc: david.marchand@redhat.com References: <1603496581-35966-1-git-send-email-nicolas.chautru@intel.com> <1603496581-35966-8-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: <2740f83e-d995-3b8b-2536-bec618c35d1e@redhat.com> Date: Mon, 26 Oct 2020 06:55:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1603496581-35966-8-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v5 7/7] app/bbdev: update offload test to dequeue full ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/23/20 4:43 PM, Nicolas Chautru wrote: > update offload dequeue to retrieve the full ring to be > agnostic of implementation. > > Signed-off-by: Nicolas Chautru > Acked-by: Aidan Goddard > Acked-by: Dave Burley > --- > app/test-bbdev/test_bbdev_perf.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index b5dc536..a6884c5 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -4463,8 +4463,8 @@ typedef int (test_case_function)(struct active_device *ad, > /* Dequeue one operation */ This comment and similar need to change, not doing just 1 anymore > do { > deq += rte_bbdev_dequeue_dec_ops(dev_id, queue_id, > - &ops_deq[deq], 1); > - } while (unlikely(deq != 1)); > + &ops_deq[deq], enq); > + } while (unlikely(deq == 0)); This check looks wrong, should likely be (deq != enq) Similar below Tom > > deq_last_time = rte_rdtsc_precise() - deq_start_time; > time_st->deq_max_time = RTE_MAX(time_st->deq_max_time, > @@ -4554,8 +4554,8 @@ typedef int (test_case_function)(struct active_device *ad, > /* Dequeue one operation */ > do { > deq += rte_bbdev_dequeue_ldpc_dec_ops(dev_id, queue_id, > - &ops_deq[deq], 1); > - } while (unlikely(deq != 1)); > + &ops_deq[deq], enq); > + } while (unlikely(deq == 0)); > > deq_last_time = rte_rdtsc_precise() - deq_start_time; > time_st->deq_max_time = RTE_MAX(time_st->deq_max_time, > @@ -4642,8 +4642,8 @@ typedef int (test_case_function)(struct active_device *ad, > /* Dequeue one operation */ > do { > deq += rte_bbdev_dequeue_enc_ops(dev_id, queue_id, > - &ops_deq[deq], 1); > - } while (unlikely(deq != 1)); > + &ops_deq[deq], enq); > + } while (unlikely(deq == 0)); > > deq_last_time = rte_rdtsc_precise() - deq_start_time; > time_st->deq_max_time = RTE_MAX(time_st->deq_max_time, > @@ -4725,8 +4725,8 @@ typedef int (test_case_function)(struct active_device *ad, > /* Dequeue one operation */ > do { > deq += rte_bbdev_dequeue_ldpc_enc_ops(dev_id, queue_id, > - &ops_deq[deq], 1); > - } while (unlikely(deq != 1)); > + &ops_deq[deq], enq); > + } while (unlikely(deq == 0)); > > deq_last_time = rte_rdtsc_precise() - deq_start_time; > time_st->deq_max_time = RTE_MAX(time_st->deq_max_time,