From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CD9CA0547; Tue, 9 Feb 2021 13:34:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A91AB160679; Tue, 9 Feb 2021 13:34:50 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 2F31040147; Tue, 9 Feb 2021 13:34:49 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 28FBCE17; Tue, 9 Feb 2021 07:34:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 09 Feb 2021 07:34:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= GhbIc1JscV54+00xRe5MvzvIq19hMFTEbJ7FnZZ4k8c=; b=gM9arjyg707lIGoy 1RoO6BjdYU05d3w/xlYyt+NPOvyPa8Av+XqcdDpv1OBJ+xsCVl8QLEigX7yQPLHd +J+2T2D5qL7C4jCpifDVT2q+iWDgKZiI3dqmJ0ib/XyQVVELvyTP48XCyjUXmoqG gftMJ0EowGpiX6Yrgjoc0Zsx66pMT2N23ditIqbxVyCtbDmSMHaiu+/M9wslhbDK 8rl0jIhQWscaNub4WxT8Hwi2lbgpUG9iZdVdc/uYhUXxuH83Cu1GD9N63R8JtG8T 7DRXntvN3+w9oXvGuiH5zkqFU/QtCaQTOpcMkhcn96JbUNxdenEqk1dggng0tDWC q96owA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=GhbIc1JscV54+00xRe5MvzvIq19hMFTEbJ7FnZZ4k 8c=; b=n18pGgCmYFMQap3dGfQ2CaUmSd5oIZGNRL2ME52cRj/bIDrQv4ilFPmLP n50gh2LpE1vQ6BL0ZtPQapjmEgsuVZn3ebbGY4BqCYpbrUsaRlu3lNZu7g9N/xLK TYPRZz4GvpJyWU3s1XtF1u4wRBIxHIJAJ1jcTjD3NbfyoC+ZEddOqTtIBzqiSMFf jNgw2vdSB8eAJGYHf8HuJcrRnTWCBZSZX3yAnoxAwZHc5wnWigoQTOUsJYwkRMTX vdEOqlWX/8lQTfSoacQGydJIPa0/hZVLyBjpqMP4Ssxcngc6mOGzd108Igmi0kri FPjgFpiLphDf20kz173MqvSQXYHnA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheehgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C7A89108005C; Tue, 9 Feb 2021 07:34:42 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org, Ray Kinsella , Neil Horman , Kevin Laatz Date: Tue, 09 Feb 2021 13:34:40 +0100 Message-ID: <2748803.ThAVpoFO8R@thomas> In-Reply-To: <20210205212606.GA1479@bricha3-MOBL.ger.corp.intel.com> References: <20210205193933.410011-1-bruce.richardson@intel.com> <1695007.lsEMqjsl9x@thomas> <20210205212606.GA1479@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix querying DPDK version at runtime X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/02/2021 22:26, Bruce Richardson: > On Fri, Feb 05, 2021 at 09:05:43PM +0100, Thomas Monjalon wrote: > > 05/02/2021 20:39, Bruce Richardson: > > > For using a DPDK application, such as OVS, which is dynamically linked, the > > > DPDK version in use should always report the actual version, not the > > > version used at build time. This incorrect behaviour can be seen by > > > building OVS against one version of DPDK and running it against a later > > > one. Using "ovs-vsctl list Open_vSwitch" to query basic info, the > > > dpdk_version returned will be the build version not the currently running > > > one - which can be verified using the DPDK telemetry library client. > > > > > > $ sudo ovs-vsctl list Open_vSwitch | grep dpdk_version > > > dpdk_version : "DPDK 20.11.0-rc4" > > > > > > $ echo quit | sudo dpdk-telemetry.py > > > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > > > {"version": "DPDK 21.02.0-rc2", "pid": 405659, "max_output_len": 16384} > > > > Nice demonstration. > > > > > __rte_experimental > > > int > > > -rte_telemetry_init(const char *runtime_dir, rte_cpuset_t *cpuset, > > > +rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset, > > > const char **err_str); > > > > It is changing the API. > > As it is experimental, you just need to mention it in the release notes. > > I don't think I actually need to mention it there, because this API is more > "INTERNAL" than "EXPERIMENTAL". It's called automatically from > rte_eal_init(). I've done up patch http://patches.dpdk.org/patch/87806/ > to correct this, including a RN addition. That should remove the need for a > doc update for this patch. > > > > > It is the fix. Do you think it should be merged quickly? > > Or wait for 21.05? > > > > I'm not sure either way to be honest. Given the bug has been around so > long, it's not exactly urgent. On the other hand, to get the fix the user > needs to rebuild their app, so having it sooner is nicer, and will mean it > would make the next LTS point release. Overall, though, I'm fine whichever > you decide. There is not much help available to close 21.02, so I won't take any risk. I'll merge this fix in 21.05.