From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 48889312 for ; Thu, 12 Jun 2014 17:36:22 +0200 (CEST) Received: by mail-wi0-f179.google.com with SMTP id cc10so3221461wib.6 for ; Thu, 12 Jun 2014 08:36:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Ddkdx/acj3jMpsC2DCh+/Tb+P1mhWIJzOvEaqcUtcuI=; b=GrIAzEMsIRcWpTuPgZPZLhjRvdj7117GbXMNmZD7N4VztNVMuZHEkXmlJOYbI2Eq9E 0Fbyr9Ed3m6+nMD4jcfh8ezqficDQ/9Uxed347tOsenK1wq7GpZv9KVKUXkYqNovkiVK XS4PWTTVS+Lg2DL4Wy+FqfRQ0pemiw483RxxN4EyQ3YMT4xXvLhn0BS3XpgFsckJ1c8p 1mOMYBgHe7tiQxfycFoJr515iQJ9MoQ+2U3FabtO2FVW8Rh3NXeXJEa+EYTf3o7X4P/L 9TEm5WCPILkix86zTqJ9R4AZgxjHUa4DgwXEFw1+z5T9kT/eUsSUWAMLCVZ41uGY1B47 juww== X-Gm-Message-State: ALoCoQnDzvof88syKIwQvVr6mh4YTQIP2PX45xM4JTxJih8RxnzRTE9JlQ18Y54QeRpAjzxG8Oql X-Received: by 10.194.243.3 with SMTP id wu3mr62912521wjc.29.1402587394447; Thu, 12 Jun 2014 08:36:34 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id l4sm4725332wiy.0.2014.06.12.08.36.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jun 2014 08:36:33 -0700 (PDT) From: Thomas Monjalon To: Vladimir Medvedkin Date: Thu, 12 Jun 2014 17:36:31 +0200 Message-ID: <27520622.tiYQNKLyvh@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8A8BBB5@SHSMSX104.ccr.corp.intel.com> References: <1400895442-32433-1-git-send-email-jingjing.wu@intel.com> <2116871.SYCYqgDKRI@xps13> <9BB6961774997848B5B42BEC655768F8A8BBB5@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jun 2014 15:36:22 -0000 > 2014-06-11 17:45, Thomas Monjalon: > > My main concern is that Vladimir Medvedkin suggested another API and I'd > > like you give your opinion about it: > > http://dpdk.org/ml/archives/dev/2014-June/003053.html > > It offers pool number in configuration of the filters. 2014-06-12 08:08, Wu, Jingjing: > The pool field is used in virtualization scenario. It is acting as one of > input set during filter matching in ixgbe. > My patch didn't consider the virtualization scenario in generic filter > feature. Because in 82599 datasheet, it is recommended to assign rx queues > not used by DCB/RSS, that is virtualization without RSS and DCB mode. For > this mode, current DPDK version makes the number of queue to 1 by default in > IOV mode. So in this case it makes no sense make pool as a input set and the > rx queue also need to be set to in this pool, so just keep the consistent > with flow director who also ignore it in previous version. > And further E1000/Niantic/Fortville have different definitions for VF, we > need to think how to define it more generic. > And even just need offer pool number in configuration of the filters as what > Vladimir did, it also need to verify the interworking with Virtualization > for different kinds of NICs, and the interworking with DCB and RSS which is > not recommended in 82599's datasheet. > So I think it will be a good choice to implement generic filter interworking > with virtualization in future patch. If there is any volunteer to send patch > for support this concern later, it will be also cool. Vladimir, do you agree with this analysis? As you suggested another implementation, I need you acknowledgment for this patchset to be integrated. Thanks -- Thomas