From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 2220F1B20A
 for <dev@dpdk.org>; Fri, 20 Oct 2017 12:52:58 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B1C6C21110;
 Fri, 20 Oct 2017 06:52:57 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Fri, 20 Oct 2017 06:52:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=CeyaUxog2/MZ/Jiaq5tCjUACX4
 wqg1J9OtVVCEyvvmE=; b=JZTdEj2+fkS1LTN6kp2Br9d0NLOw/eyQI+EyUzIW9N
 iq81Dqz21khF8d26AqnjNzPiLrscOf3xlvMCTxdnvpgRhyKzkcfJnKGoo5mFXL+C
 XE0P1337N6W7T0qYFisQyvHUMA0Oqe4UCiWbw9r2tlo0+YT3/z9WbfVNa2kHInPV
 s=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=CeyaUx
 og2/MZ/Jiaq5tCjUACX4wqg1J9OtVVCEyvvmE=; b=cFztg1XnSJlHjFi857TPGk
 ZHj1XXZ5zZP4WEDOEqW2IxxXnE8nhBQBJMp8FfDrl/stjiBrS9lQK4FVI5uapEv4
 8m/lglMay47vJlGaniqntZgJXXqHvnyjhPPc/4K2QLwD1X1Vl3I42/ricqw5Qed1
 yOyOEN1XUqL6T8wsOFSXr5kodPU2z2hG8h/K13af4F4iituXK3pMKFUg7+o+VtLQ
 Tr84FienNw1WpDh2bbPlipY7/MugIcHAEN5pL8vMQxz7aJUEROgeooqXjQ/nDUsw
 NhMa7nqSJqLmXbYR4+LB5oUmVn8wwCm3bknMvbNljUQSYW2hUHHrc7o45/ssn4Ew
 ==
X-ME-Sender: <xms:idXpWXRvlGJIelEVySrUY_C2UbvITwqxF1ZSO7QHMs3AvT5w9AboyQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 5D74824135;
 Fri, 20 Oct 2017 06:52:57 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "aviadye@dev.mellanox.co.il" <aviadye@dev.mellanox.co.il>,
 "aviadye@mellanox.com" <aviadye@mellanox.com>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, dev@dpdk.org,
 "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
 "borisp@mellanox.com" <borisp@mellanox.com>,
 "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Nicolau,
 Radu" <radu.nicolau@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>,
 "liranl@mellanox.com" <liranl@mellanox.com>,
 "nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>
Date: Fri, 20 Oct 2017 12:52:56 +0200
Message-ID: <2754764.nFg3Fio5kK@xps>
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC38599@IRSMSX108.ger.corp.intel.com>
References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il>
 <1508439184-17893-3-git-send-email-aviadye@dev.mellanox.co.il>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC38599@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 3/6] examples/ipsec-secgw: fix aad_len for
	for aes-gcm
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Oct 2017 10:52:58 -0000

20/10/2017 11:52, De Lara Guarch, Pablo:
> Same comments as in patch 1, and also fix the commit title
> ("for" duplicated) and avoid "_".

The underscore is forbidden in titles to avoid naming variable or
function names instead of giving a clear scope understandable
without digging in the code.
Here "aad_len" can probably be replaced by "AAD length".