DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add eal clean up to the example
Date: Wed, 14 Apr 2021 10:12:47 +0800
Message-ID: <27561131-9f2f-2799-7c3c-567d53e0a35f@huawei.com> (raw)
In-Reply-To: <6ffcacd6-b14e-9628-6953-f64549e36792@huawei.com>



在 2021/4/8 21:09, Min Hu (Connor) 写道:
> 
> 
> 在 2021/4/8 19:21, David Marchand 写道:
>> On Thu, Apr 8, 2021 at 12:17 PM Min Hu (Connor) <humin29@huawei.com> 
>> wrote:
>>>
>>> From: Chengchang Tang <tangchengchang@huawei.com>
>>>
>>> According to the programming guide, the rte_eal_init should be used 
>>> pairs
>>> with rte_eal_cleanup.
>>>
>>> So, we should add the use of clean up to the hello world example to
>>> encourage new users of DPDK to use it.
>>>
>>> Fixes: af75078fece3 ("first public release")
>>
>> rte_eal_cleanup() was introduced with aec9c13c5257 ("eal: add function
>> to release internal resources") from v18.02.
>>
>> Other examples probably need fixes too.
>> $ git grep -l rte_eal_init examples/ |xargs grep -L rte_eal_cleanup |wc
>>       52      52    1623
>>
> Thanks David,
>      I will fix other examples in next patches.
>>
Hi, David and all,
	I have sent one set of patches to fix it, the headline is
	"[PATCH 00/45] add eal clean up to the example"
	Please review it, thanks.
> .

      reply	other threads:[~2021-04-14  2:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 10:17 Min Hu (Connor)
2021-04-08 11:21 ` David Marchand
2021-04-08 13:09   ` Min Hu (Connor)
2021-04-14  2:12     ` Min Hu (Connor) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27561131-9f2f-2799-7c3c-567d53e0a35f@huawei.com \
    --to=humin29@huawei.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git